gh-124176: Add special support for dataclasses to create_autospec #124429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ericvsmith reviewed Sep 25, 2024
Member
ericvsmith left a comment
ericvsmith left a comment There was a problem hiding this comment.
I'm not a user of unittest.mock, but these changes look reasonable to me.
carljm approved these changes Sep 25, 2024
Member
carljm left a comment
carljm left a comment There was a problem hiding this comment.
This looks reasonable to me as well.
ericvsmith approved these changes Sep 25, 2024
cjw296 reviewed Sep 26, 2024
cjw296 requested changes Sep 26, 2024
Contributor
cjw296 left a comment
cjw296 left a comment There was a problem hiding this comment.
Supportive of the change, just the code hygiene changes to make.
| When you're done making the requested changes, leave the comment: |
Member Author
| @cjw296 done! 👍 |
cjw296 reviewed Sep 26, 2024
ncoghlan approved these changes Sep 27, 2024
Member Author
| Thanks everyone! 🎉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Now creating autospecs from dataclass types is easier. We inspect all fields and add them to
__dir__, so mock's spec will know about future dataclass instance fields.