gh-112795: Allow / folder in a zipfile #112932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
erlend-aasland changed the title / folder in a zipfile/ folder in a zipfile 
gpshead reviewed Jan 6, 2024
gpshead added needs backport to 3.11 
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2024
Allow extraction (no-op) of a "/" folder in a zipfile, they are commonly added by some archive creation tools. (cherry picked from commit 541c5db) Co-authored-by: AN Long <aisk@users.noreply.github.com> Co-authored-by: Erlend E. Aasland <erlend@python.org> Co-authored-by: Gregory P. Smith <greg@krypto.org>
| GH-113789 is a backport of this pull request to the 3.12 branch. |
gpshead added a commit that referenced this pull request Jan 7, 2024
gh-112795: Allow `/` folder in a zipfile (GH-112932) Allow extraction (no-op) of a "/" folder in a zipfile, they are commonly added by some archive creation tools. (cherry picked from commit 541c5db) Co-authored-by: AN Long <aisk@users.noreply.github.com> Co-authored-by: Erlend E. Aasland <erlend@python.org> Co-authored-by: Gregory P. Smith <greg@krypto.org>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
| Thanks for the view! The buildbot failed and complains |
| someone has subscribed apple support to the email address for this issue? i'm locking it for a while. |
jaraco reviewed Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This behavior is introduced in #98346 (comment), but as #112795 shows, some tools such as jira or self structeded tools do have
/in the file lists in the created zip file. And modern unzip tools support them, so I think we should revert the change.If this PR can be accepted, it should be backported to 3.12.