Fixed stroke on FreeType < 2.9 #4401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Thank you! |
This was referenced Mar 6, 2021
This was referenced Mar 17, 2021
Bump pillow from 4.0.0 to 7.1.0 in /study_material/intro-to-tensorflow tiandiao123/deep_learning#121
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #4366
The issue reported that the stroke was incorrectly positioned when writing the text 'Sample Overlay Text'. Testing for that issue, I found that it was only happening for FreeType < 2.9 - all three of the values being used in calculating the ascender (
bitmap.rows,glyph_slot->bitmap_topandPIXEL(glyph_info[i].y_offset)) were zero. I find that always passing inFT_LOAD_RENDERwhen loading the glyphs for those calculations fixes that.However, FreeType < 2.9 is a scenario in our test environments, so why wasn't this picked up? It's because 'Sample Overlay Text' has descenders - 'p' and 'y' go below the baseline of the text. The current stroke text tests involve 'A', 'A\nB' and 'ABC\nAaaa' - no descenders.