move fixture finalizing to pytest_fixture_teardown hook

[ShurikMen]

solution #12163

[rplevka]

I was just about to submit a PR with almost identical code changes when I discovered yours :)
Changes are looking great, but I think you want to append the new-hook reference to the docs here

[rplevka]

that failing test does not seem to be related to the contributed code

[RonnyPfannschmidt]

this looks good to me, how does this interact with pytest-asyncio?

[ShurikMen]

this looks good to me, how does this interact with pytest-asyncio?

For pytest-asyncio, everything should work without additional improvements

[bluetech]

Marking "Request changes" as per my comment on the issue: #12163 (comment)

@ShurikMen @rplevka please let me know in the issue if you have any specific use case for pytest_fixture_teardown instead of extending pytest_fixture_post_finalizer

[ShurikMen]

Marking "Request changes" as per my comment on the issue: #12163 (comment)

@ShurikMen @rplevka please let me know in the issue if you have any specific use case for pytest_fixture_teardown instead of extending pytest_fixture_post_finalizer

I use it like this #12163 (comment)

[ogajduse]

@bluetech Can the community be of any help to help to push this PR forward? The discussion in #12163 seems to be waiting for your response.

[rplevka]

@RonnyPfannschmidt help, please? I think this has been stale for some time. We think the change makes perfect sense and we would really find it useful in our project.
Thank you.

[RonnyPfannschmidt]

im also waiting for a reply from @bluetech - i think the concerns mentioned need to be addressed

[ogajduse]

@RonnyPfannschmidt Are there any concerns that should be addressed by the community? If so, could you please let us know what are these? I believe that concerns @bluetech had were answered in #12163.
It is already 5 months since this has been open. I would like to know whether there is any chance merging it or we should be looking into a completely different approach or a place to put the logic in.

[RonnyPfannschmidt]

@bluetech ping - can we add a fresh comment here whats still missing to progress this - its unclear to me if the reply in the issue addressed your concern sufficiently or not

[RonnyPfannschmidt]

i did some re-reading - and the concerns haven't been resolved - i need a better understanding of the use-case and actual exampel of the use-ases involved as im getting a X-Y problem gut feeling