make async tests and tests that return non-None fail instead of warn #12346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Zac-HD reviewed May 21, 2024
There was a problem hiding this comment.
👋 Hi Phebe! This looks good to me overall - three things to do:
- Moving the exception definition, as below
- Doing the various TODOs in comments
- Edit the top comment to link to the issue for awareness and auto-closing, and briefly describe the issue.
| Hi folks, Sorry why is this being done? Is there an issue related to it? |
| Suggested in #11372 🙂 (and we're at the PyCon US sprints, so most communication about this has been verbal instead of online) |
| Ahh OK, no worries, thanks @Zac-HD! If possible it helps adding the issue number in the PR description for context. 👍 |
graingert previously requested changes Oct 23, 2024
…. Make tests fail instead of raising warning/exception. fix tests. add changelog.
psf-chronographer bot added the bot:chronographer:provided 
| Did an overhaul of the implementation, I don't think creating exceptions in I also implemented ReturnNotNone, because it felt minimal and similar enough to just get done. Couldn't find an issue to link the newsfragment to though so I just pointed it to this PR. codecov seems somewhat confused, but afaict everything is actually fine. |
jakkdl changed the title Zac-HD approved these changes Oct 25, 2024
There was a problem hiding this comment.
Thanks @polkapolka and @jakkdl for your work on this! I'm looking forward to using it myself 😁
nicoddemus reviewed Nov 6, 2024
jakkdl pushed a commit to jakkdl/pytest that referenced this pull request Nov 11, 2024
Glyphack pushed a commit to Glyphack/pytest that referenced this pull request Nov 23, 2024
38 tasks
2 tasks
sai-rekhawar pushed a commit to sai-rekhawar/cloe-nessy-py that referenced this pull request Jul 1, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pytest](https://github.com/pytest-dev/pytest) ([changelog](https://docs.pytest.org/en/stable/changelog.html)) | dependency-groups | major | `<8.0.0,>=7.4.4` -> `<8.5.0,>=8.4.0` | --- ### Release Notes <details> <summary>pytest-dev/pytest (pytest)</summary> ### [`v8.4.0`](https://github.com/pytest-dev/pytest/releases/tag/8.4.0) [Compare Source](pytest-dev/pytest@8.3.5...8.4.0) ### pytest 8.4.0 (2025-06-02) #### Removals and backward incompatible breaking changes - [#​11372](pytest-dev/pytest#11372): Async tests will now fail, instead of warning+skipping, if you don't have any suitable plugin installed. - [#​12346](pytest-dev/pytest#12346): Tests will now fail, instead of raising a warning, if they return any value other than None. - [#​12874](pytest-dev/pytest#12874): We dropped support for Python 3.8 following its end of life (2024-10-07). - [#​12960](pytest-dev/pytest#12960): Test functions containing a yield now cause an explicit error. They have not been run since pytest 4.0, and were previously marked as an expected failure and deprecation warning. See `the docs <yield tests deprecated>`{.interpreted-text role="ref"} for more information. #### Deprecations (removal in next major release) - [#​10839](pytest-dev/pytest#10839): Requesting an asynchronous fixture without a \[pytest_fixture_setup]{.title-ref} hook that resolves it will now give a DeprecationWarning. This most commonly happens if a sync test requests an async fixture. This should have no effect on a majority of users with async tests or fixtures using async pytest plugins, but may affect non-standard hook setups or `autouse=True`. For guidance on how to work around this warning see `sync-test-async-fixture`{.interpreted-text role="ref"}. #### New features - [#​11538](pytest-dev/pytest#11538): Added `pytest.RaisesGroup`{.interpreted-text role="class"} as an equivalent to `pytest.raises`{.interpreted-text role="func"} for expecting `ExceptionGroup`{.interpreted-text role="exc"}. Also adds `pytest.RaisesExc`{.interpreted-text role="class"} which is now the logic behind `pytest.raises`{.interpreted-text role="func"} and used as parameter to `pytest.RaisesGroup`{.interpreted-text role="class"}. `RaisesGroup` includes the ability to specify multiple different expected exceptions, the structure of nested exception groups, and flags for emulating `except* <except_star>`{.interpreted-text role="ref"}. See `assert-matching-exception-groups`{.interpreted-text role="ref"} and docstrings for more information. - [#​12081](pytest-dev/pytest#12081): Added `capteesys`{.interpreted-text role="fixture"} to capture AND pass...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.