Skip to content

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Aug 19, 2025

Was reading through the changelog and found this amusing brain fart I introduced in #979
Turns out I've contributed to way too many flake8-* projects x)

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.91%. Comparing base (d2245df) to head (8fbe0ea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #1198 +/- ## ======================================= Coverage 88.91% 88.91% ======================================= Files 2 2 Lines 406 406 Branches 44 44 ======================================= Hits 361 361 Misses 35 35 Partials 10 10 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@jakkdl
Copy link
Member Author

jakkdl commented Aug 20, 2025

oh turns out the warning message is also wrong

@seifertm seifertm added this to the v1.1 milestone Aug 24, 2025
@seifertm
Copy link
Contributor

Thanks! I have to admit that I spotted this when initially merging the PR, but didn't question it 😅 . I did a brief search for the corresponding package and found you as one of the maintainers, so the message seemed intentional.

I took the liberty to change the deprecation message as well. @jakkdl Are we good to go with this from your point of view?

@jakkdl
Copy link
Member Author

jakkdl commented Aug 24, 2025

Haha no yeah flake8-async (without the "io") is what caused me to confuse the two, but it'll never have any checks about pytest-asyncio fixture misuse 😅

Looks great!

@seifertm seifertm added this pull request to the merge queue Aug 24, 2025
@seifertm seifertm changed the title fix typo in changelog flake8-asyncio -> pytest-asyncio fix typos flake8-asyncio -> pytest-asyncio Aug 24, 2025
Merged via the queue into main with commit 5900a4d Aug 24, 2025
21 of 22 checks passed
@seifertm seifertm deleted the jakkdl-patch-1 branch August 24, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants