Skip to content

Commit 0b53ed7

Browse files
authored
style: add pyupgrade to pre-commit (#414)
1 parent 3dd3287 commit 0b53ed7

File tree

5 files changed

+16
-12
lines changed

5 files changed

+16
-12
lines changed

.pre-commit-config.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ repos:
1414
exclude: '^(docs|tasks|tests)|setup\.py'
1515
args: []
1616

17+
- repo: https://github.com/asottile/pyupgrade
18+
rev: v2.29.0
19+
hooks:
20+
- id: pyupgrade
21+
args: [--py36-plus]
22+
1723
- repo: https://github.com/psf/black
1824
rev: 20.8b1
1925
hooks:

tests/test_markers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def test_str(self, value):
6868

6969
@pytest.mark.parametrize("value", ["one", "two", None, 3, 5, []])
7070
def test_repr(self, value):
71-
assert repr(Node(value)) == "<Node({!r})>".format(str(value))
71+
assert repr(Node(value)) == f"<Node({str(value)!r})>"
7272

7373
def test_base_class(self):
7474
with pytest.raises(NotImplementedError):
@@ -205,7 +205,7 @@ def test_parses_invalid(self, marker_string):
205205
def test_str_and_repr(self, marker_string, expected):
206206
m = Marker(marker_string)
207207
assert str(m) == expected
208-
assert repr(m) == "<Marker({!r})>".format(str(m))
208+
assert repr(m) == f"<Marker({str(m)!r})>"
209209

210210
def test_extra_with_no_extra_in_environment(self):
211211
# We can't evaluate an extra if no extra is passed into the environment

tests/test_specifiers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ def test_specifiers_str_and_repr(self, specifier, expected):
227227
spec = Specifier(specifier)
228228

229229
assert str(spec) == expected
230-
assert repr(spec) == "<Specifier({!r})>".format(expected)
230+
assert repr(spec) == f"<Specifier({expected!r})>"
231231

232232
@pytest.mark.parametrize("specifier", SPECIFIERS)
233233
def test_specifiers_hash(self, specifier):
@@ -873,7 +873,7 @@ def test_specifiers_str_and_repr(self, specifier, expected):
873873
spec = SpecifierSet(specifier)
874874

875875
assert str(spec) == expected
876-
assert repr(spec) == "<SpecifierSet({!r})>".format(expected)
876+
assert repr(spec) == f"<SpecifierSet({expected!r})>"
877877

878878
@pytest.mark.parametrize("specifier", SPECIFIERS + LEGACY_SPECIFIERS)
879879
def test_specifiers_hash(self, specifier):

tests/test_tags.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -228,12 +228,10 @@ def test_version_detection(self, monkeypatch):
228228
platform, "mac_ver", lambda: ("10.14", ("", "", ""), "x86_64")
229229
)
230230
version = platform.mac_ver()[0].split(".")
231-
if version[0] == "10":
232-
expected = "macosx_{major}_{minor}".format(
233-
major=version[0], minor=version[1]
234-
)
235-
else:
236-
expected = "macosx_{major}_{minor}".format(major=version[0], minor=0)
231+
major = version[0]
232+
minor = version[1] if major == "10" else "0"
233+
expected = f"macosx_{major}_{minor}"
234+
237235
platforms = list(tags.mac_platforms(arch="x86_64"))
238236
print(platforms, expected)
239237
assert platforms[0].startswith(expected)
@@ -608,7 +606,7 @@ def test__debug_cp38(self, debug, expected, monkeypatch):
608606
def test_pymalloc(self, pymalloc, version, result, monkeypatch):
609607
config = {"Py_DEBUG": 0, "WITH_PYMALLOC": pymalloc, "Py_UNICODE_SIZE": 2}
610608
monkeypatch.setattr(sysconfig, "get_config_var", config.__getitem__)
611-
base_abi = "cp{}{}".format(version[0], version[1])
609+
base_abi = f"cp{version[0]}{version[1]}"
612610
expected = [base_abi + "m" if result else base_abi]
613611
assert tags._cpython_abis(version) == expected
614612

tests/test_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ def test_normalized_versions(self, version, normalized):
277277
)
278278
def test_version_str_repr(self, version, expected):
279279
assert str(Version(version)) == expected
280-
assert repr(Version(version)) == "<Version({!r})>".format(expected)
280+
assert repr(Version(version)) == f"<Version({expected!r})>"
281281

282282
def test_version_rc_and_c_equals(self):
283283
assert Version("1.0rc1") == Version("1.0c1")

0 commit comments

Comments
 (0)