Skip to content

Fix doctest warnings, enable errors in CI #7166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 16, 2022
Merged

Fix doctest warnings, enable errors in CI #7166

merged 6 commits into from
Oct 16, 2022

Conversation

@max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Oct 16, 2022 •
edited
Loading

I'm not confident about the CI change; either we can merge with the "this is a trial message" and see how it goes, or split that into a separate PR and discuss.
@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Oct 16, 2022
@max-sixty
Copy link
Collaborator Author

max-sixty commented Oct 16, 2022

Currently this raises a deprecation warning:

xarray/xarray/backends/rasterio_.py

Line 193 in 50301ac

>>> da = xr.open_rasterio(

Possibly we add something to the doctest to ignore warnings? It'll be out of place in the docs though...
@Illviljan
Copy link
Contributor

Illviljan commented Oct 16, 2022 •
edited
Loading

open_rasterio has been deprecated for like a year, #5808. Is it time to remove it?

You can also just remove the example from the docstring, this is on minimal support anyway.
@max-sixty
Copy link
Collaborator Author

max-sixty commented Oct 16, 2022 •
edited
Loading

You can also just remove the example from the docstring, this is on minimal support anyway.

Great, done
headtr1ck
headtr1ck approved these changes Oct 16, 2022
View reviewed changes
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
@max-sixty
Copy link
Collaborator Author

max-sixty commented Oct 16, 2022

OK, let's give this a whirl!
@max-sixty max-sixty enabled auto-merge (squash) October 16, 2022 21:05
@max-sixty max-sixty merged commit 24d038f into pydata:main Oct 16, 2022
dcherian added a commit to shoyer/xarray that referenced this pull request Oct 17, 2022
@dcherian
Merge branch 'main' into file-manager-not-shared
4dfbfc4 
* main: Add import ASV benchmark (pydata#7176) Rework docs about scatter plots (pydata#7169) Fix some scatter plot issues (pydata#7167) Fix doctest warnings, enable errors in CI (pydata#7166) fix broken test (pydata#7168) Add typing to plot methods (pydata#7052) Fix warning in doctest (pydata#7165) dev whats-new (pydata#7161) v2022.10.0 whats-new (pydata#7160)
dcherian added a commit to JessicaS11/xarray that referenced this pull request Oct 17, 2022
@dcherian
Merge branch 'main' into listbackends
988af43 
* main: Add import ASV benchmark (pydata#7176) Rework docs about scatter plots (pydata#7169) Fix some scatter plot issues (pydata#7167) Fix doctest warnings, enable errors in CI (pydata#7166) fix broken test (pydata#7168) Add typing to plot methods (pydata#7052) Fix warning in doctest (pydata#7165)
@max-sixty max-sixty deleted the warning-doctest branch September 20, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Automation Github bots, testing workflows, release automation io topic-backends

3 participants

@max-sixty @Illviljan @headtr1ck