fix shorthand struct initialization lint

Author: cameron1024

proptest-macro/src/property_test/codegen/snapshots/proptest_macro__property_test__codegen__snapshot_tests__arg_ident_and_pattern.snap

@@ -1475,13 +1475,6 @@ TokenStream [
  Group {
  delimiter: Brace,
  stream: TokenStream [
- Ident {
- sym: a,
- },
- Punct {
- char: ':',
- spacing: Alone,
- },
  Ident {
  sym: a,
  },
@@ -1518,13 +1511,6 @@ TokenStream [
  Ident {
  sym: d,
  },
- Punct {
- char: ':',
- spacing: Alone,
- },
- Ident {
- sym: d,
- },
  Punct {
  char: ',',
  spacing: Alone,
@@ -1580,13 +1566,6 @@ TokenStream [
  Ident {
  sym: h,
  },
- Punct {
- char: ':',
- spacing: Alone,
- },
- Ident {
- sym: h,
- },
  Punct {
  char: ',',
  spacing: Alone,

proptest-macro/src/property_test/codegen/snapshots/proptest_macro__property_test__codegen__snapshot_tests__many_params.snap

@@ -1090,13 +1090,6 @@ TokenStream [
  Group {
  delimiter: Brace,
  stream: TokenStream [
- Ident {
- sym: x,
- },
- Punct {
- char: ':',
- spacing: Alone,
- },
  Ident {
  sym: x,
  },
@@ -1107,13 +1100,6 @@ TokenStream [
  Ident {
  sym: y,
  },
- Punct {
- char: ':',
- spacing: Alone,
- },
- Ident {
- sym: y,
- },
  Punct {
  char: ',',
  spacing: Alone,

proptest-macro/src/property_test/codegen/snapshots/proptest_macro__property_test__codegen__snapshot_tests__simple.snap

@@ -1041,13 +1041,6 @@ TokenStream [
  Group {
  delimiter: Brace,
  stream: TokenStream [
- Ident {
- sym: x,
- },
- Punct {
- char: ':',
- spacing: Alone,
- },
  Ident {
  sym: x,
  },

proptest-macro/src/property_test/codegen/test_body.rs

@@ -1,6 +1,6 @@
 use proc_macro2::TokenStream;
 use quote::{quote, ToTokens};
-use syn::{parse2, Block, Expr, Ident, ReturnType, Type, TypeTuple};
+use syn::{parse2, Block, Expr, Ident, Pat, ReturnType, Type, TypeTuple};
 
 use crate::property_test::{options::Options, utils::Argument};
 
@@ -22,9 +22,17 @@ pub(super) fn body(
 
  // convert each arg to `field0: x`
  let struct_fields = args.iter().enumerate().map(|(index, arg)| {
- let pat = &arg.pat_ty.pat;
+ let pat = arg.pat_ty.pat.as_ref();
  let field_name = nth_field_name(args, index);
- quote!(#field_name: #pat,)
+
+ // If the pattern is an ident, we know that the field name is equal to the pattern name.
+ // This means we need to avoid generating: `x: x`, which would trigger a lint suggesting
+ // shorthand struct initialization.
+
+ match pat {
+ Pat::Ident(_) => quote!(#field_name,),
+ _ => quote!(#field_name: #pat,),
+ }
  });
 
  // e.g. FooArgs { field0: x, field1: (y, z), }

proptest-macro/src/property_test/tests/snapshots/proptest_macro__property_test__tests__snapshot_tests__basic_derive_example.snap

@@ -34,7 +34,7 @@ fn foo() {
  ::proptest::sugar::NamedArguments(stringify!(FooArgs), values)
  },
  ),
- |::proptest::sugar::NamedArguments(_, FooArgs { x: x, y: y })| {
+ |::proptest::sugar::NamedArguments(_, FooArgs { x, y })| {
  let result = {
  let x = 1;
  };

proptest-macro/src/property_test/tests/snapshots/proptest_macro__property_test__tests__snapshot_tests__custom_strategy.snap

@@ -33,7 +33,7 @@ fn foo() {
  ::proptest::sugar::NamedArguments(stringify!(FooArgs), values)
  },
  ),
- |::proptest::sugar::NamedArguments(_, FooArgs { x: x, y: y })| {
+ |::proptest::sugar::NamedArguments(_, FooArgs { x, y })| {
  let result = {
  let x = 1;
  };

proptest-macro/src/property_test/tests/snapshots/proptest_macro__property_test__tests__snapshot_tests__mix_custom_and_default_strategies.snap

@@ -33,7 +33,7 @@ fn foo() {
  ::proptest::sugar::NamedArguments(stringify!(FooArgs), values)
  },
  ),
- |::proptest::sugar::NamedArguments(_, FooArgs { x: x, y: y })| {
+ |::proptest::sugar::NamedArguments(_, FooArgs { x, y })| {
  let result = {
  let x = 1;
  };