Fix exclude-databases for collector package #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| also, this fixes #588 |
SuperQ reviewed Oct 4, 2022
Contributor Author
| @SuperQ Good idea. I removed the commented code. |
| @sysadmind you planning on fixing the conflicts? |
The pg_database collector was not respecting the --exclude-databases flag and causing problems where databases were not accessible. This now respects the list of databases to exclude. - Adjusts the Collector create func to take a config struct instead of a logger. This allows more changes like this in the future. I figured we would need to do this at some point but I wasn't sure if we could hold off. - Split the database size collection to a separate query when database is not excluded. - Comment some probe code that was not useful/accurate Signed-off-by: Joe Adams <github@joeadams.io>
sysadmind force-pushed the exclude-database-fix branch from 44301fc to 66f6e11 Compare Signed-off-by: Joe Adams <github@joeadams.io>
sysadmind force-pushed the exclude-database-fix branch from 66f6e11 to 8d6ce05 Compare SuperQ requested changes Mar 5, 2023
Contributor
SuperQ left a comment
SuperQ left a comment There was a problem hiding this comment.
One more remove dead code.
Signed-off-by: Joe Adams <github@joeadams.io>
SuperQ approved these changes Mar 5, 2023
macmiranda referenced this pull request Mar 6, 2023
* Update Go to 1.20. * Update golanci-lint. * Bump modules. * Update CI orb. * Fix up use of deprecated ioutil. Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The pg_database collector was not respecting the --exclude-databases flag and causing problems where databases were not accessible. This now respects the list of databases to exclude.
Signed-off-by: Joe Adams github@joeadams.io