Skip to content

Commit 6a9dddd

Browse files
committed
downloading ffmpeg as part of build process; make sure it has exec
1 parent 72266b8 commit 6a9dddd

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

build/build.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,12 @@
335335
<fileset dir="shared/tools" />
336336
</copy>
337337

338+
<!-- make sure ffmpeg/ffmpeg.exe have exec permission -->
339+
<condition property="ffmpeg.binary" value="ffmpeg.exe" else="ffmpeg">
340+
<os family="windows" />
341+
</condition>
342+
<chmod file="${target.path}/tools/MovieMaker/tool/${ffmpeg.binary}" perm="ugo+x" />
343+
338344
<copy todir="${target.path}/modes/java" preservelastmodified="true">
339345
<fileset dir="../java">
340346
<!-- don't include LWJGL, it's not operational -->
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
bin
2+
ffmpeg-*.gz
3+
24

35

46

build/shared/tools/MovieMaker/build.xml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
</and>
2121
</condition>
2222

23-
<condition property="ffmpeg.filename" value="ffmpeg.exe" else="ffmpeg">
23+
<condition property="ffmpeg.binary" value="tool/ffmpeg.exe" else="tool/ffmpeg">
2424
<os family="windows" />
2525
</condition>
2626

@@ -29,7 +29,7 @@
2929
from several locations, and are all packaged differently.
3030
This could be automated, but too much effort relative to utility. -->
3131
<property name="ffmpeg.url"
32-
value="https://download.processing.org/ffmpeg/${ffmpeg.version}/$ffmpeg-${platform}-${os.arch}.gz" />
32+
value="https://download.processing.org/ffmpeg/${ffmpeg.version}/ffmpeg-${platform}-${os.arch}.gz" />
3333

3434
<property name="ffmpeg.gz" value="ffmpeg-${ffmpeg.version}.gz" />
3535
<available file="${ffmpeg.gz}" property="ffmpeg.present" />
@@ -47,8 +47,11 @@
4747
dest="${ffmpeg.gz}"
4848
ignoreerrors="${ffmpeg.ignorable}"
4949
usetimestamp="true" />
50+
</target>
5051

51-
<gunzip src="${ffmpeg.gz}" dest="${ffmpeg.filename}" />
52+
<target name="prepare-ffmpeg" depends="download-ffmpeg">
53+
<gunzip src="${ffmpeg.gz}" dest="${ffmpeg.binary}" />
54+
<chmod file="${ffmpeg.binary}" perm="ugo+x" />
5255
</target>
5356

5457
<target name="clean" description="Clean the build directories">
@@ -74,7 +77,7 @@
7477
</javac>
7578
</target>
7679

77-
<target name="build" depends="compile, download-ffmpeg" description="Build Movie Maker Tool">
80+
<target name="build" depends="compile, prepare-ffmpeg" description="Build Movie Maker Tool">
7881
<mkdir dir="tool" />
7982
<jar basedir="bin" destfile="tool/MovieMaker.jar" />
8083
</target>

0 commit comments

Comments
 (0)