Skip to content

Commit ebd985d

Browse files
bmccannsoumith
authored andcommitted
params should not be reinitialized for loaded models
1 parent fc52742 commit ebd985d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

OpenNMT/train.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,6 @@ def eval(model, criterion, data):
151151
def trainModel(model, trainData, validData, dataset, optim):
152152
print(model)
153153
model.train()
154-
for p in model.parameters():
155-
p.data.uniform_(-opt.param_init, opt.param_init)
156154

157155
# define criterion of each GPU
158156
criterion = NMTCriterion(dataset['dicts']['tgt'].size())
@@ -258,6 +256,8 @@ def main():
258256
lr_decay=opt.learning_rate_decay,
259257
start_decay_at=opt.start_decay_at
260258
)
259+
for p in model.parameters():
260+
p.data.uniform_(-opt.param_init, opt.param_init)
261261
else:
262262
print('Loading from checkpoint at %s' % opt.train_from)
263263
checkpoint = torch.load(opt.train_from)

0 commit comments

Comments
 (0)