minor symfony#44037 Never rely on dynamic properties (nicolas-grekas)

This PR was merged into the 4.4 branch. Discussion ---------- Never rely on dynamic properties | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As described in https://wiki.php.net/rfc/deprecate_dynamic_properties Commits ------- aa4fb0c Never rely on dynamic properties

Author: chalasr

src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/ProxyDumperTest.php

@@ -196,6 +196,8 @@ function ($definition) {
 
 final class DummyClass implements DummyInterface, SunnyInterface
 {
+ private $ref;
+
  public function dummy()
  {
  return $this;

src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php

@@ -253,7 +253,6 @@ public function testGetServiceIds()
  {
  $builder = new ContainerBuilder();
  $builder->register('foo', 'stdClass');
- $builder->bar = $bar = new \stdClass();
  $builder->register('bar', 'stdClass');
  $this->assertEquals(
  [

src/Symfony/Component/DependencyInjection/Tests/Fixtures/StdClassDecorator.php

@@ -4,6 +4,8 @@
 
 final class StdClassDecorator
 {
+ public $foo;
+
  public function __construct(\stdClass $foo)
  {
  $this->foo = $foo;

src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/classes.php

@@ -142,6 +142,8 @@ public static function create($config)
 
 class FoobarCircular
 {
+ public $foo;
+
  public function __construct(FooCircular $foo)
  {
  $this->foo = $foo;
@@ -150,6 +152,8 @@ public function __construct(FooCircular $foo)
 
 class FooCircular
 {
+ public $bar;
+
  public function __construct(BarCircular $bar)
  {
  $this->bar = $bar;
@@ -158,6 +162,8 @@ public function __construct(BarCircular $bar)
 
 class BarCircular
 {
+ public $foobar;
+
  public function addFoobar(FoobarCircular $foobar)
  {
  $this->foobar = $foobar;

src/Symfony/Component/EventDispatcher/Tests/EventDispatcherTest.php

@@ -458,6 +458,7 @@ public function __invoke()
 
 class TestEventListener
 {
+ public $name;
  public $preFooInvoked = false;
  public $postFooInvoked = false;
 

src/Symfony/Component/HttpKernel/Tests/Fixtures/KernelForTest.php

@@ -19,7 +19,7 @@ class KernelForTest extends Kernel
 {
  public function getBundleMap()
  {
- return $this->bundleMap;
+ return [];
  }
 
  public function registerBundles(): iterable

src/Symfony/Component/Mime/Part/DataPart.php

@@ -20,6 +20,9 @@
  */
 class DataPart extends TextPart
 {
+ /** @internal */
+ protected $_parent;
+
  private static $mimeTypes;
 
  private $filename;
@@ -32,6 +35,8 @@ class DataPart extends TextPart
  */
  public function __construct($body, string $filename = null, string $contentType = null, string $encoding = null)
  {
+ unset($this->_parent);
+
  if (null === $contentType) {
  $contentType = 'application/octet-stream';
  }

src/Symfony/Component/Mime/Part/SMimePart.php

@@ -18,6 +18,9 @@
  */
 class SMimePart extends AbstractPart
 {
+ /** @internal */
+ protected $_headers;
+
  private $body;
  private $type;
  private $subtype;
@@ -28,6 +31,8 @@ class SMimePart extends AbstractPart
  */
  public function __construct($body, string $type, string $subtype, array $parameters)
  {
+ unset($this->_headers);
+
  parent::__construct();
 
  if (!\is_string($body) && !is_iterable($body)) {

src/Symfony/Component/Mime/Part/TextPart.php

@@ -23,6 +23,9 @@
  */
 class TextPart extends AbstractPart
 {
+ /** @internal */
+ protected $_headers;
+
  private static $encoders = [];
 
  private $body;
@@ -37,6 +40,8 @@ class TextPart extends AbstractPart
  */
  public function __construct($body, ?string $charset = 'utf-8', string $subtype = 'plain', string $encoding = null)
  {
+ unset($this->_headers);
+
  parent::__construct();
 
  if (!\is_string($body) && !\is_resource($body)) {

src/Symfony/Component/Security/Core/Exception/AuthenticationException.php

@@ -21,8 +21,17 @@
  */
 class AuthenticationException extends RuntimeException
 {
+ /** @internal */
+ protected $serialized;
+
  private $token;
 
+ public function __construct(string $message = '', int $code = 0, \Throwable $previous = null)
+ {
+ unset($this->serialized);
+ parent::__construct($message, $code, $previous);
+ }
+
  /**
  * Get the token.
  *