bug symfony#48224 [DependencyInjection] Process bindings in ServiceLocatorTagPass (MatTheCat)

This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Process bindings in `ServiceLocatorTagPass` | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#48192 | License | MIT | Doc PR | N/A Commits ------- 81d0858 [DependencyInjection] Process bindings in ServiceLocatorTagPass

Author: fabpot

src/Symfony/Component/DependencyInjection/Compiler/ServiceLocatorTagPass.php

@@ -39,6 +39,10 @@ protected function processValue($value, $isRoot = false)
  return self::register($this->container, $value->getValues());
  }
 
+ if ($value instanceof Definition) {
+ $value->setBindings(parent::processValue($value->getBindings()));
+ }
+
  if (!$value instanceof Definition || !$value->hasTag('container.service_locator')) {
  return parent::processValue($value, $isRoot);
  }

src/Symfony/Component/DependencyInjection/Tests/Compiler/ServiceLocatorTagPassTest.php

@@ -13,6 +13,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\Argument\BoundArgument;
+use Symfony\Component\DependencyInjection\Argument\ServiceLocatorArgument;
 use Symfony\Component\DependencyInjection\Compiler\ServiceLocatorTagPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
@@ -143,4 +144,16 @@ public function testBindingsAreCopied()
  $this->assertSame(['foo'], array_keys($locator->getBindings()));
  $this->assertInstanceOf(BoundArgument::class, $locator->getBindings()['foo']);
  }
+
+ public function testBindingsAreProcessed()
+ {
+ $container = new ContainerBuilder();
+
+ $definition = $container->register('foo')
+ ->setBindings(['foo' => new ServiceLocatorArgument()]);
+
+ (new ServiceLocatorTagPass())->process($container);
+
+ $this->assertInstanceOf(Reference::class, $definition->getBindings()['foo']->getValues()[0]);
+ }
 }