DATAREDIS-626 - Refactor RedisConnection implementations to Redis feature-specific interfaces.

We refactored JedisConnection and LettuceConnection from monolithic connection classes into modular classes that organize methods according the Redis feature group and created segregated interfaces per Redis feature group. Segregated interfaces reduce the number of methods available on the interface to the used data type. This refactoring reduces the responsibility of JedisConnection/LettuceConnection and JedisClusterConnection/LettuceClusterConnection to a minimum of commands. To preserve backwards-compatibility with users of the connection classes, we introduced DefaultedRedisConnection and DefaultedRedisClusterConnection to forward calls from the connection facade to the specific implementation. Deprecation of connection facade method assists migration off these methods towards using methods on the feature group interface. LettuceConnection connection = … connection.keyCommands().del(key); connection.hashCommands().hSet(key, field, value); Original pull request: spring-projects#247.

Author: christophstrobl

src/main/java/org/springframework/data/redis/connection/AbstractRedisConnection.java

@@ -27,7 +27,7 @@
  * @author Christoph Strobl
  * @since 1.4
  */
-public abstract class AbstractRedisConnection implements RedisConnection {
+public abstract class AbstractRedisConnection implements DefaultedRedisConnection {
 
 private RedisSentinelConfiguration sentinelConfiguration;
 private ConcurrentHashMap<RedisNode, RedisSentinelConnection> connectionCache = new ConcurrentHashMap<RedisNode, RedisSentinelConnection>();

src/main/java/org/springframework/data/redis/connection/DefaultStringRedisConnection.java

@@ -3034,7 +3034,7 @@ public Set<byte[]> zRangeByScore(byte[] key, String min, String max, long offset
 
 /*
  * (non-Javadoc)
- * @see org.springframework.data.redis.connection.HyperLogLogCommands#pfAdd(byte[], byte[][])
+ * @see org.springframework.data.redis.connection.RedisHyperLogLogCommands#pfAdd(byte[], byte[][])
  */
 @Override
 public Long pfAdd(byte[] key, byte[]... values) {
@@ -3052,7 +3052,7 @@ public Long pfAdd(String key, String... values) {
 
 /*
  * (non-Javadoc)
- * @see org.springframework.data.redis.connection.HyperLogLogCommands#pfCount(byte[][])
+ * @see org.springframework.data.redis.connection.RedisHyperLogLogCommands#pfCount(byte[][])
  */
 @Override
 public Long pfCount(byte[]... keys) {
@@ -3070,7 +3070,7 @@ public Long pfCount(String... keys) {
 
 /*
  * (non-Javadoc)
- * @see org.springframework.data.redis.connection.HyperLogLogCommands#pfMerge(byte[], byte[][])
+ * @see org.springframework.data.redis.connection.RedisHyperLogLogCommands#pfMerge(byte[], byte[][])
  */
 @Override
 public void pfMerge(byte[] destinationKey, byte[]... sourceKeys) {

src/main/java/org/springframework/data/redis/connection/DefaultedRedisClusterConnection.java

@@ -0,0 +1,24 @@
+/*
+ * Copyright 2017 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.data.redis.connection;
+
+/**
+ * @author Christoph Strobl
+ * @since 2.0
+ */
+public interface DefaultedRedisClusterConnection extends RedisClusterConnection, DefaultedRedisConnection {
+
+}