Fix for variadic params

Author: staabm

src/Reflection/Php/PhpFunctionReflection.php

@@ -152,7 +152,7 @@ private function isVariadic(): bool
 $cachedResult = $this->cache->load($key, $variableCacheKey);
 if ($cachedResult === null) {
 $nodes = $this->parser->parseFile($fileName);
-$result = !$this->callsFuncGetArgs($nodes)->no();
+$result = !$this->containsVariadicFunction($nodes)->no();
 $this->cache->save($key, $variableCacheKey, $result);
 return $result;
 }
@@ -167,7 +167,7 @@ private function isVariadic(): bool
 /**
  * @param Node[]|scalar[]|Node $node
  */
-private function callsFuncGetArgs(array|Node $node): TrinaryLogic
+private function containsVariadicFunction(array|Node $node): TrinaryLogic
 {
 $result = TrinaryLogic::createMaybe();
 
@@ -176,8 +176,7 @@ private function callsFuncGetArgs(array|Node $node): TrinaryLogic
 $functionName = (string) $node->namespacedName;
 
 if ($functionName === $this->reflection->getName()) {
-// native variadic with ...$param is checked via ReflectionFunction->isVariadic()
-return TrinaryLogic::createFromBoolean($this->functionCallStatementFinder->findFunctionCallInStatements(ParametersAcceptor::VARIADIC_FUNCTIONS, $node->getStmts()) !== null);
+return TrinaryLogic::createFromBoolean($this->isFunctionNodeVariadic($node));
 }
 }
 
@@ -187,15 +186,15 @@ private function callsFuncGetArgs(array|Node $node): TrinaryLogic
 continue;
 }
 
-$result = $result->and($this->callsFuncGetArgs($innerNode));
+$result = $result->and($this->containsVariadicFunction($innerNode));
 }
 } elseif (is_array($node)) {
 foreach ($node as $subNode) {
 if (!$subNode instanceof Node) {
 continue;
 }
 
-$result = $result->and($this->callsFuncGetArgs($subNode));
+$result = $result->and($this->containsVariadicFunction($subNode));
 }
 }
 
@@ -301,4 +300,19 @@ public function acceptsNamedArguments(): bool
 return $this->acceptsNamedArguments;
 }
 
+private function isFunctionNodeVariadic(Function_ $node): bool
+{
+foreach ($node->params as $parameter) {
+if ($parameter->variadic) {
+return true;
+}
+}
+
+if ($this->functionCallStatementFinder->findFunctionCallInStatements(ParametersAcceptor::VARIADIC_FUNCTIONS, $node->getStmts()) !== null) {
+return true;
+}
+
+return false;
+}
+
 }

tests/PHPStan/Rules/Functions/data/bug-11559b.php

@@ -68,3 +68,15 @@ function maybe_variadic_fn4(...$values) {
 function variadic_fn5(...$values) {
 }
 variadic_fn5('action','asdf');
+
+
+if (rand(0,1)) {
+function maybe_variadic_fn6($x, $y): void {
+}
+} else if ( ! function_exists( 'maybe_variadic_fn6' ) ) {
+function maybe_variadic_fn6($y, ...$values): void {
+}
+}
+
+maybe_variadic_fn6('action','asdf');
+