Fix edge-case with in_array and enums

Author: ondrejmirtes

phpstan-baseline.neon

@@ -1307,6 +1307,14 @@ parameters:
 count: 2
 path: src/Type/Php/InArrayFunctionTypeSpecifyingExtension.php
 
+-
+message: """
+#^Call to deprecated method getEnumCaseObjects\\(\\) of class PHPStan\\\\Type\\\\TypeUtils\\:
+Use Type\\:\\:getEnumCases\\(\\)$#
+"""
+count: 2
+path: src/Type/Php/InArrayFunctionTypeSpecifyingExtension.php
+
 -
 message: "#^Doing instanceof PHPStan\\\\Type\\\\Constant\\\\ConstantStringType is error\\-prone and deprecated\\. Use Type\\:\\:getConstantStrings\\(\\) instead\\.$#"
 count: 1

src/Type/Php/InArrayFunctionTypeSpecifyingExtension.php

@@ -54,7 +54,7 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n
 if (
 $context->truthy()
 || count(TypeUtils::getConstantScalars($arrayValueType)) > 0
-|| count($arrayValueType->getEnumCases()) > 0
+|| count(TypeUtils::getEnumCaseObjects($arrayValueType)) > 0
 ) {
 $specifiedTypes = $this->typeSpecifier->create(
 $node->getArgs()[0]->value,
@@ -68,7 +68,7 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n
 if (
 $context->truthy()
 || count(TypeUtils::getConstantScalars($needleType)) > 0
-|| count($needleType->getEnumCases()) > 0
+|| count(TypeUtils::getEnumCaseObjects($needleType)) > 0
 ) {
 if ($context->truthy()) {
 $arrayValueType = TypeCombinator::union($arrayValueType, $needleType);

tests/PHPStan/Analyser/data/enums.php

@@ -2,6 +2,7 @@
 
 namespace EnumTypeAssertions;
 
+use function in_array;
 use function PHPStan\Testing\assertType;
 
 enum Foo
@@ -266,3 +267,20 @@ public function doBar()
 }
 
 }
+
+class InArrayEnum
+{
+
+/** @var list<Foo> */
+private $list;
+
+public function doFoo(Foo $foo): void
+{
+if (in_array($foo, $this->list, true)) {
+return;
+}
+
+assertType(Foo::class, $foo);
+}
+
+}