Try

Author: VincentLanglet

src/PhpDoc/PhpDocNodeResolver.php

@@ -705,12 +705,12 @@ public function resolveIsImpure(PhpDocNode $phpDocNode): bool
 return false;
 }
 
-public function resolveAllMethodsArePure(PhpDocNode $phpDocNode): bool
+public function resolveAllMethodsPure(PhpDocNode $phpDocNode): bool
 {
 return count($phpDocNode->getTagsByName('@phpstan-all-methods-pure')) > 0;
 }
 
-public function resolveAllMethodsAreImpure(PhpDocNode $phpDocNode): bool
+public function resolveAllMethodsImpure(PhpDocNode $phpDocNode): bool
 {
 return count($phpDocNode->getTagsByName('@phpstan-all-methods-impure')) > 0;
 }

src/PhpDoc/ResolvedPhpDocBlock.php

@@ -139,8 +139,9 @@ final class ResolvedPhpDocBlock
 /** @var bool|'notLoaded'|null */
 private bool|string|null $isPure = 'notLoaded';
 
-/** @var bool|'notLoaded'|null */
-private bool|string|null $defaultMethodPurity = 'notLoaded';
+private ?bool $areAllMethodsPure = null;
+
+private ?bool $areAllMethodsImpure = null;
 
 private ?bool $isReadOnly = null;
 
@@ -236,7 +237,8 @@ public static function createEmpty(): self
 $self->isInternal = false;
 $self->isFinal = false;
 $self->isPure = null;
-$self->defaultMethodPurity = null;
+$self->areAllMethodsPure = false;
+$self->areAllMethodsImpure = false;
 $self->isReadOnly = false;
 $self->isImmutable = false;
 $self->isAllowedPrivateMutation = false;
@@ -302,7 +304,8 @@ public function merge(array $parents, array $parentPhpDocBlocks): self
 $result->isInternal = $this->isInternal();
 $result->isFinal = $this->isFinal();
 $result->isPure = self::mergePureTags($this->isPure(), $parents);
-$result->defaultMethodPurity = $this->getDefaultMethodPurity();
+$result->areAllMethodsPure = $this->areAllMethodsPure();
+$result->areAllMethodsImpure = $this->areAllMethodsImpure();
 $result->isReadOnly = $this->isReadOnly();
 $result->isImmutable = $this->isImmutable();
 $result->isAllowedPrivateMutation = $this->isAllowedPrivateMutation();
@@ -423,7 +426,6 @@ public function changeParameterNamesByMapping(array $parameterNameMapping): self
 $self->isInternal = $this->isInternal;
 $self->isFinal = $this->isFinal;
 $self->isPure = $this->isPure;
-$self->defaultMethodPurity = $this->defaultMethodPurity;
 
 return $self;
 }
@@ -833,29 +835,18 @@ public function isPure(): ?bool
 return $this->isPure;
 }
 
-public function getDefaultMethodPurity(): ?bool
+public function areAllMethodsPure(): bool
 {
-if ($this->defaultMethodPurity === 'notLoaded') {
-$pure = $this->phpDocNodeResolver->resolveAllMethodsArePure(
-$this->phpDocNode,
-);
-if ($pure) {
-$this->defaultMethodPurity = true;
-return $this->defaultMethodPurity;
-}
-
-$impure = $this->phpDocNodeResolver->resolveAllMethodsAreImpure(
-$this->phpDocNode,
-);
-if ($impure) {
-$this->defaultMethodPurity = false;
-return $this->defaultMethodPurity;
-}
-
-$this->defaultMethodPurity = null;
-}
+return $this->areAllMethodsPure ??= $this->phpDocNodeResolver->resolveAllMethodsPure(
+$this->phpDocNode,
+);
+}
 
-return $this->defaultMethodPurity;
+public function areAllMethodsImpure(): bool
+{
+return $this->areAllMethodsImpure ??= $this->phpDocNodeResolver->resolveAllMethodsImpure(
+$this->phpDocNode,
+);
 }
 
 public function isReadOnly(): bool

src/Reflection/ClassReflection.php

@@ -113,9 +113,6 @@ final class ClassReflection
 
 private ?bool $hasConsistentConstructor = null;
 
-/** @var bool|'notLoaded'|null */
-private bool|string|null $defaultMethodPurity = 'notLoaded';
-
 private ?bool $acceptsNamedArguments = null;
 
 private ?TemplateTypeMap $templateTypeMap = null;
@@ -1495,20 +1492,6 @@ public function hasConsistentConstructor(): bool
 return $this->hasConsistentConstructor;
 }
 
-public function getDefaultMethodPurity(): ?bool
-{
-if ($this->defaultMethodPurity === 'notLoaded') {
-$resolvedPhpDoc = $this->getResolvedPhpDoc();
-if ($resolvedPhpDoc === null) {
-$this->defaultMethodPurity = null;
-} else {
-$this->defaultMethodPurity = $resolvedPhpDoc->getDefaultMethodPurity();
-}
-}
-
-return $this->defaultMethodPurity;
-}
-
 public function acceptsNamedArguments(): bool
 {
 if ($this->acceptsNamedArguments === null) {

src/Reflection/Php/PhpClassReflectionExtension.php

@@ -892,7 +892,16 @@ public function createUserlandMethodReflection(ClassReflection $fileDeclaringCla
 }
 }
 
-$isPure ??= $resolvedPhpDoc->isPure() ?? $phpDocBlockClassReflection->getDefaultMethodPurity();
+$isPure ??= $resolvedPhpDoc->isPure();
+if ($isPure === null) {
+$classResolvedPhpDoc = $phpDocBlockClassReflection->getResolvedPhpDoc();
+if ($classResolvedPhpDoc !== null && $classResolvedPhpDoc->areAllMethodsPure()) {
+$isPure = true;
+} elseif ($classResolvedPhpDoc !== null && $classResolvedPhpDoc->areAllMethodsImpure()) {
+$isPure = false;
+}
+}
+
 $asserts = Assertions::createFromResolvedPhpDocBlock($resolvedPhpDoc);
 $acceptsNamedArguments = $resolvedPhpDoc->acceptsNamedArguments();
 $selfOutType = $resolvedPhpDoc->getSelfOutTag() !== null ? $resolvedPhpDoc->getSelfOutTag()->getType() : null;