LogicalXor is not shortcircuited

Author: ondrejmirtes

src/Rules/Comparison/LogicalXorConstantConditionRule.php

@@ -63,7 +63,7 @@ public function processNode(Node $node, Scope $scope): array
 }
 
 $rightType = $this->helper->getBooleanType($scope, $node->right);
-if ($rightType instanceof ConstantBooleanType && !$scope->isInFirstLevelStatement()) {
+if ($rightType instanceof ConstantBooleanType) {
 $addTipRight = function (RuleErrorBuilder $ruleErrorBuilder) use ($scope, $node, $tipText): RuleErrorBuilder {
 if (!$this->treatPhpDocTypesAsCertain) {
 return $ruleErrorBuilder;

tests/PHPStan/Rules/Comparison/LogicalXorConstantConditionRuleTest.php

@@ -65,6 +65,14 @@ public function testRule(): void
 20,
 $tipText,
 ],
+[
+'Left side of xor is always true.',
+24,
+],
+[
+'Right side of xor is always false.',
+24,
+],
 ]);
 }
 

tests/PHPStan/Rules/Comparison/data/logical-xor.php

@@ -20,6 +20,8 @@ public function doFoo($a, $b)
 if ($a xor $b) {
 
 }
+
+1 xor 0;
 }
 
 }