Regression tests

Closes phpstan/phpstan#7491 Closes phpstan/phpstan#4004 Closes phpstan/phpstan#2499

Author: ondrejmirtes

tests/PHPStan/Rules/Comparison/BooleanOrConstantConditionRuleTest.php

@@ -438,4 +438,11 @@ public function testBug6551(): void
 $this->analyse([__DIR__ . '/data/bug-6551.php'], []);
 }
 
+public function testBug4004(): void
+{
+$this->treatPhpDocTypesAsCertain = true;
+$this->reportAlwaysTrueInLastCondition = true;
+$this->analyse([__DIR__ . '/data/bug-4004.php'], []);
+}
+
 }

tests/PHPStan/Rules/Comparison/IfConstantConditionRuleTest.php

@@ -150,4 +150,16 @@ public function testBug4302(): void
 $this->analyse([__DIR__ . '/data/bug-4302.php'], []);
 }
 
+public function testBug7491(): void
+{
+$this->treatPhpDocTypesAsCertain = true;
+$this->analyse([__DIR__ . '/data/bug-7491.php'], []);
+}
+
+public function testBug2499(): void
+{
+$this->treatPhpDocTypesAsCertain = true;
+$this->analyse([__DIR__ . '/data/bug-2499.php'], []);
+}
+
 }

tests/PHPStan/Rules/Comparison/UnreachableIfBranchesRuleTest.php

@@ -130,4 +130,10 @@ public function testBug8562(): void
 $this->analyse([__DIR__ . '/data/bug-8562.php'], []);
 }
 
+public function testBug7491(): void
+{
+$this->treatPhpDocTypesAsCertain = true;
+$this->analyse([__DIR__ . '/data/bug-7491.php'], []);
+}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-2499.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Bug2499;
+
+function (): void {
+$value = 123;
+
+if ($value = $_GET['name'] and is_string($value)) {
+echo $value;
+}
+};

tests/PHPStan/Rules/Comparison/data/bug-4004.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Bug4004;
+
+function (): void {
+$pupKey = '';
+$privateR = '';
+
+$original = "I just wanna tell you how I'm feeling\nGotta make you understand";
+$encrypted = '';
+$decrypted = '';
+
+if (! @\openssl_public_encrypt($original, $encrypted, $pupKey, OPENSSL_PKCS1_OAEP_PADDING)) {
+throw new \Exception('Unable to encrypt data, invalid key provided?');
+}
+
+if (! @\openssl_private_decrypt($encrypted, $decrypted, $privateR, OPENSSL_PKCS1_OAEP_PADDING) || $decrypted !== $original) {
+throw new \Exception();
+}
+};

tests/PHPStan/Rules/Comparison/data/bug-7491.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Bug7491;
+
+function test(string $text = ''): bool {
+$world = preg_match('/\b(world)$/i', $text, $matches) === false ? '' : ($matches[1] ?? '');
+if ($world == '') {
+echo "Not found\n";
+return false;
+} else {
+echo "Found '$world'\n";
+return true;
+}
+}