Any variable can exist after include/require

Author: ondrejmirtes

src/Analyser/NodeScopeResolver.php

@@ -2609,7 +2609,7 @@ static function (): void {
 $throwPoints = $result->getThrowPoints();
 $throwPoints[] = ThrowPoint::createImplicit($scope, $expr);
 $hasYield = $result->hasYield();
-$scope = $result->getScope();
+$scope = $result->getScope()->afterExtractCall();
 } elseif (
 $expr instanceof Expr\BitwiseNot
 || $expr instanceof Cast

tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php

@@ -215,27 +215,23 @@ public function testDefinedVariables(): void
 360,
 ],
 [
-'Undefined variable: $variableInWhileIsset',
-365,
-],
-[
-'Undefined variable: $unknownVariablePassedToReset',
+'Variable $unknownVariablePassedToReset might not be defined.',
 368,
 ],
 [
-'Undefined variable: $unknownVariablePassedToReset',
+'Variable $unknownVariablePassedToReset might not be defined.',
 369,
 ],
 [
-'Undefined variable: $variableInAssign',
+'Variable $variableInAssign might not be defined.',
 384,
 ],
 [
-'Undefined variable: $undefinedArrayIndex',
+'Variable $undefinedArrayIndex might not be defined.',
 409,
 ],
 [
-'Undefined variable: $anotherUndefinedArrayIndex',
+'Variable $anotherUndefinedArrayIndex might not be defined.',
 409,
 ],
 [
@@ -1024,4 +1020,13 @@ public function testIsStringNarrowsCertainty(): void
 ]);
 }
 
+public function testDiscussion10252(): void
+{
+$this->cliArgumentsVariablesRegistered = true;
+$this->polluteScopeWithLoopInitialAssignments = true;
+$this->checkMaybeUndefinedVariables = true;
+$this->polluteScopeWithAlwaysIterableForeach = true;
+$this->analyse([__DIR__ . '/data/discussion-10252.php'], []);
+}
+
 }

tests/PHPStan/Rules/Variables/data/discussion-10252.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Discussion10252;
+
+function sayIt(): void
+{
+require 'who-to-love.php';
+
+/** @var string $name */
+echo 'I love you, ' . $name .'!';
+}