Fix memory consumption in DataProviderDataRule

Author: ondrejmirtes

src/Rules/PHPUnit/DataProviderDataRule.php

@@ -84,23 +84,28 @@ public function processNode(Node $node, Scope $scope): array
 return [];
 }
 
-$maxNumberOfParameters = $testsWithProvider[0]->getNumberOfParameters();
-if (count($testsWithProvider) > 1) {
-foreach ($testsWithProvider as $testMethod) {
-if ($testMethod->isVariadic()) {
-$maxNumberOfParameters = PHP_INT_MAX;
-break;
-}
+$maxNumberOfParameters = null;
+foreach ($testsWithProvider as $testMethod) {
+$num = $testMethod->getNumberOfParameters();
+if ($testMethod->isVariadic()) {
+$num = PHP_INT_MAX;
+}
+if ($maxNumberOfParameters === null) {
+$maxNumberOfParameters = $num;
+continue;
+}
 
-$maxNumberOfParameters = max($maxNumberOfParameters, $testMethod->getNumberOfParameters());
+$maxNumberOfParameters = max($maxNumberOfParameters, $num);
+if ($num === PHP_INT_MAX) {
+break;
 }
 }
 
 foreach ($testsWithProvider as $testMethod) {
 $numberOfParameters = $testMethod->getNumberOfParameters();
 
 foreach ($arraysTypes as [$startLine, $arraysType]) {
-$args = $this->arrayItemsToArgs($arraysType, $maxNumberOfParameters);
+$args = $this->arrayItemsToArgs($arraysType, $numberOfParameters);
 if ($args === null) {
 continue;
 }

tests/Rules/PHPUnit/data/data-provider-trimming-args.php

@@ -30,3 +30,37 @@ public function testProvide2(int $i): void
 }
 
 }
+
+class BarTest extends TestCase
+{
+
+/**
+ * @return array<array<string>>
+ */
+public function getData(): array
+{
+return [];
+}
+
+public function dataProvide(): array
+{
+return $this->getData();
+}
+
+/**
+ * @dataProvider dataProvide
+ */
+public function testProvide(string ...$arg): void
+{
+
+}
+
+/**
+ * @dataProvider dataProvide
+ */
+public function testProvide2(string $arg): void
+{
+
+}
+
+}