Skip to content

Commit 41a3bf4

Browse files
committed
- support for copy of ICU DLLS for all ICU versions
1 parent 03f4121 commit 41a3bf4

File tree

1 file changed

+8
-17
lines changed

1 file changed

+8
-17
lines changed

win32/build/mkdist.php

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function get_depends($module)
5858
* but the debug version (msvcrtd.dll) and those from visual studio.net
5959
* (msvcrt7x.dll) are not */
6060
'msvcrt.dll',
61-
61+
'wldap32.dll'
6262
);
6363
global $build_dir, $extra_dll_deps, $ext_targets, $sapi_targets, $pecl_targets, $phpdll, $per_module_deps, $pecl_dll_deps;
6464

@@ -295,22 +295,13 @@ function extract_file_from_tarball($pkg, $filename, $dest_dir) /* {{{ */
295295
copy($dll, "$dist_dir/" . basename($dll));
296296
}
297297

298-
$ICU_DLLS = array(
299-
'icudt36.dll',
300-
'icuin36.dll',
301-
'icuio36.dll',
302-
'icule36.dll',
303-
'iculx36.dll',
304-
'icutu36.dll',
305-
'icuuc36.dll'
306-
);
307-
foreach ($ICU_DLLS as $dll) {
308-
$tdll = '../deps/bin/' . basename($dll);
309-
if (!file_exists($tdll)) {
310-
echo "WARNING: distro depends on $dll, but could not find it on your system\n";
311-
continue;
312-
}
313-
copy($tdll, "$dist_dir/" . basename($dll));
298+
/* TODO:
299+
add sanity check and test if all required DLLs are present, per version
300+
This version works at least for 3.6, 3.8 and 4.0 (5.3-vc6, 5.3-vc9 and HEAD).
301+
*/
302+
$ICU_DLLS = '../deps/bin/' . 'icudt*.dll';
303+
foreach (glob($ICU_DLLS) as $filename) {
304+
copy($filename, "$dist_dir/" . basename($dll));
314305
}
315306

316307
/* and those for pecl */

0 commit comments

Comments
 (0)