BatchConsumer loop after SIGTERM #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- start only pliles messages until out of memory. - no exception are thrown by addMessage or maybeStopConsumer
| Good catch @nturato , thanks for the fix! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request solves a bug I discovered on the BatchConsumer.
When sent a SIGTERM or SIGINT if at least one message of the batch was loaded it would start looping until reaching the maximum function nesting and throwing a fatal error.
loop chain is:
stopConsumer -> batchConsume -> handleProcessMessages -> maybeStopConsumer -> stopConsumer
this also causes the same batch of messages to be processed multiple times.