Fix isRamAlmostOverloaded function in Consumer #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hello, maybe need change something? |
stloyd reviewed May 29, 2017
| $memoryManager = new MemoryConsumptionChecker(new NativeMemoryUsageProvider()); | ||
| | ||
| return $memoryManager->isRamAlmostOverloaded($this->getMemoryLimit(), '5M'); | ||
| return $memoryManager->isRamAlmostOverloaded($this->getMemoryLimit().'M', '5M'); |
There was a problem hiding this comment.
We need to check & adjust if already set memory limit is not in such format.
There was a problem hiding this comment.
This check is already done by convertHumanUnitToNumerical() method.
Just a suggestion:
Alter/better documentation in the ReadMe
Its unclear the memory-limit / -l option is not in MB's by default.
The example -l 256 is 256 bytes and not 256 mega bytes.
so for reference -l=256M will be the correct notation or -l=268435456
There was a problem hiding this comment.
@adm-bome Ok, I'll do it as soon as I have time. Thanks/
| Thanks @agentsib ! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.