Add idle event and ability to configure exit or not. #419
Conversation
| { | ||
| $this->forceStop = $forceStop; | ||
| } | ||
| } |
There was a problem hiding this comment.
What about adding $forceStop = true argument to the constructor and remove the setter altogether?
Events are immutable by nature :)
There was a problem hiding this comment.
@skafandri In my case I'd like to prevent process exit and continue execution.
That's why I need a setter to change default behaviour
There was a problem hiding this comment.
I working on a cli option --time-limit="now + 2 minutes" for a consume command and to make it work I have to set idle time for wait function but it must not exit (as it was before), just return a control back to php.
There was a problem hiding this comment.
@skafandri And by the way there are a lot of examples even in symfony source code where events are not immutable. and well honestly saying they are not pure events but more like extension points of the bundle logic.
| Is there Anything I can do to get it merged? |
| README.md needs to be updated to document the new event |
| @skafandri done. |
| @skafandri is there any ETA for a stable release? |
| If I have time, this weekend, but most probably next weekend. |
2 participants
No description provided.