Skip to content

Commit 6f9b1b6

Browse files
ogriseljnothman
authored andcommitted
DOC use twine to upload wheels to pypi (scikit-learn#12661)
1 parent 32c676e commit 6f9b1b6

File tree

1 file changed

+21
-9
lines changed

1 file changed

+21
-9
lines changed

doc/developers/maintainer.rst

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,21 @@ For more information see https://github.com/scikit-learn/scikit-learn/wiki/How-t
3333

3434
$ git push origin --tags
3535

36-
4. create tarballs:
36+
4. create the source tarball:
3737

3838
- Wipe clean your repo::
3939

4040
$ git clean -xfd
4141

42-
- Register and upload on PyPI::
42+
- Generate the tarball::
4343

44-
$ python setup.py sdist register upload
44+
$ python setup.py sdist
4545

46+
The result should be in the `dist/` folder. We will upload it later
47+
with the wheels. Check that you can install it in a new virtualenv and
48+
that the tests pass.
4649

47-
5. Push the documentation to the website. Circle CI should do this
48-
automatically for master and <N>.<N>.X branches.
49-
50-
6. Build binaries using dedicated CI servers by updating the git submodule
50+
5. Build binaries using dedicated CI servers by updating the git submodule
5151
reference to the new scikit-learn tag of the release at:
5252

5353
https://github.com/MacPython/scikit-learn-wheels
@@ -56,9 +56,21 @@ For more information see https://github.com/scikit-learn/scikit-learn/wiki/How-t
5656
packages and upload them to PyPI by running the following commands in the
5757
scikit-learn source folder (checked out at the release tag)::
5858

59-
$ pip install -U wheelhouse_uploader
60-
$ python setup.py sdist fetch_artifacts upload_all
59+
$ pip install -U wheelhouse_uploader twine
60+
$ python setup.py fetch_artifacts
61+
62+
Check the content of the `dist/` folder: it should contain all the wheels
63+
along with the source tarball ("scikit-learn-XXX.tar.gz").
64+
65+
Make sure that you do not have developer versions or older versions of
66+
the scikit-learn package in that folder.
6167

68+
Upload everything at once to https://pypi.org::
69+
70+
$ twine upload dist/
71+
72+
6. Push the documentation to the website. Circle CI should do this
73+
automatically for master and <N>.<N>.X branches.
6274

6375
7. FOR FINAL RELEASE: Update the release date in What's New
6476

0 commit comments

Comments
 (0)