fix: localized block fields #14587
Merged
fix: localized block fields #14587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JarrodMFlesch requested review from AlessioGr and jacobsfletch as code owners JarrodMFlesch requested review from r1tsuu and removed request for AlessioGr and jacobsfletch 
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
JarrodMFlesch commented Nov 12, 2025
| await saveDocAndAssert(page) | ||
| await changeLocale(page, 'pt') | ||
| | ||
| await changeLocale(page, spanishLocale) |
Contributor Author
There was a problem hiding this comment.
The key here was to switch to a locale that used the locale previously filled out as a fallback. PT uses ES as a fallback so it looked like it worked. Switching it to ES made the issue appear.
JarrodMFlesch commented Nov 12, 2025
| if (collection && id) { | ||
| entitySlug = collection.slug | ||
| url = `${serverURL}${api}/${entitySlug}/${id}?depth=0&draft=true&autosave=true&locale=${localeRef.current}` | ||
| url = `${serverURL}${api}/${entitySlug}/${id}?depth=0&draft=true&autosave=true&fallback-locale=null&locale=${localeRef.current}` |
Contributor Author
There was a problem hiding this comment.
The fix was to pass fallback-locale through as query params.
DanRibbens approved these changes Nov 13, 2025
Contributor
| 🚀 This is included in version v3.64.0 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #13663
Previously #13974 was merged but it didn't actually fix the issue. I updated the tests to make them fail before making the fix in this PR.
The visual issue stemmed from to autosave not passing the
fallback-locale=nullparam. So the update function would pass the default fallback locale into afterRead and data for the nullified field would come back.The data part of that issue was previously solved by adding an array to other locales if not defined. However that clutters the db with unused data. This can be fixed by including the
formatBaseSchemain the block schema which (for localized fields) setsschema.sparse = true, so the data is only added when it is saved.