fix(next): live preview popup triggers leave without saving modal #12947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
paulpopus approved these changes Jun 26, 2025
Contributor
| 🚀 This is included in version v3.44.0 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Partially closes #12121.
When you edit a document in Live Preview using the default iframe window, then attempt to open the window as a popup, the
LeaveWithoutSavingmodal will appear.This is because the
usePreventLeavehook watches for anchor tags that might cause a page navigation, and rightfully warns the user before they navigate away and lose their changes. The reason the popup button triggers this hook is because it uses an anchor tag with an href for accessibility, which fires events that are caught and processed by the hook.The fix is to add the
target="_blank"attribute here so that the hook understands that these events do not navigate the user away from the page and can be ignored.