feat(ui): moves folder rendering from the client to the server #12710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DanRibbens reviewed Jun 9, 2025
Contributor
DanRibbens left a comment
DanRibbens left a comment There was a problem hiding this comment.
I didn't get all the way through this.
DanRibbens reviewed Jun 10, 2025
| * This will ensure that prefs are only updated when explicitly set by the user | ||
| * This could potentially be done by injecting a `sessionID` into the params and comparing it against a session cookie | ||
| */ | ||
| const browseByFolderPreferences = await upsertPreferences<{ |
Contributor
There was a problem hiding this comment.
What is the right way to do this, new ServerFunction perhaps?
DanRibbens reviewed Jun 10, 2025
| }) | ||
| } catch (error) { | ||
| // eslint-disable-next-line no-console | ||
| console.error('Error moving items:', error) |
Contributor
There was a problem hiding this comment.
Should this have toast the error instead of swallowing it?
DanRibbens approved these changes Jun 10, 2025
Contributor
DanRibbens left a comment
DanRibbens left a comment There was a problem hiding this comment.
Consider the couple places you had console.error adding toast. Otherwise it looks good to me.
elliott-w pushed a commit to elliott-w/payload that referenced this pull request Jun 12, 2025
Contributor
| 🚀 This is included in version v3.43.0 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Moves folder rendering for
collection-foldersview,browse-by-foldersview and themove-to-folderdrawer. This is how the rest of payload behaves, following this same paradigm allows the feature to integrate well with other things such as the multi-tenant plugin.