fix: correctly detect glb & gltf mimetypes during upload #12623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PatrikKozak changed the title 
JarrodMFlesch approved these changes Jun 2, 2025
Contributor
| 🚀 This is included in version v3.41.0 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What?
The browser was incorrectly setting the mimetype for
.glband.gltffiles toapplication/octet-streamwhen uploading when they should be receiving proper types consistent withglbandgltf.This patch adds logic to infer the correct
MIMEtype for.glbfiles (model/gltf-binary) &gltffiles (model/gltf+json) based on file extension during multipart processing, ensuring consistent MIME typedetection regardless of browser behavior.
Fixes #12620