Skip to content

Commit 918d59c

Browse files
committed
Add footnote when add_classes picked; a couple bug fixes in passing parameters.
1 parent 30038d9 commit 918d59c

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

pages/audio.vue

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
<CheckboxItem label="Tempo Control?" :help="helpText.tempo" v-model="abcjsParams.inlineControls.tempo"></CheckboxItem>
3434
<CheckboxItem label="Hide?" :help="helpText.hide" v-model="abcjsParams.inlineControls.hide"></CheckboxItem>
3535
<CheckboxItem label="Auto Play?" :help="helpText.startPlaying" v-model="abcjsParams.inlineControls.startPlaying"></CheckboxItem>
36-
<TextInputItem label="Pre-Inline Text (%T=title)" :help="helpText.preTextInline" v-model="abcjsParams.inlineControls.preTextInline"></TextInputItem>
37-
<TextInputItem label="Post-Inline Text (%T=title)" :help="helpText.postTextInline" v-model="abcjsParams.inlineControls.postTextInline"></TextInputItem>
36+
<TextInputItem label="Pre-Inline Text (%T=title)" :help="helpText.preTextInline" v-model="abcjsParams.preTextInline"></TextInputItem>
37+
<TextInputItem label="Post-Inline Text (%T=title)" :help="helpText.postTextInline" v-model="abcjsParams.postTextInline"></TextInputItem>
3838
<TextInputItem label="Loop Tooltip" :help="helpText.tooltipLoop" v-model="abcjsParams.inlineControls.tooltipLoop"></TextInputItem>
3939
<TextInputItem label="Reset Tooltip" :help="helpText.tooltipReset" v-model="abcjsParams.inlineControls.tooltipReset"></TextInputItem>
4040
<TextInputItem label="Play Tooltip" :help="helpText.tooltipPlay" v-model="abcjsParams.inlineControls.tooltipPlay"></TextInputItem>
@@ -295,6 +295,8 @@ ${this.formatDrumTable()}`,
295295
params += "\n generateDownload: true,";
296296
if (!this.abcjsParams.generateInline)
297297
params += "\n generateInline: false,";
298+
if (this.abcjsParams.downloadLabel !== "download midi")
299+
params += `\n downloadLabel: "${this.abcjsParams.downloadLabel}",`;
298300
if (this.abcjsParams.downloadClass !== "")
299301
params += `\n downloadClass: "${this.abcjsParams.downloadClass}",`;
300302
if (this.abcjsParams.preTextDownload !== "")

pages/interactive.vue

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,10 @@
9292
<div class="footnote">Click on the displayed music to see the output of the callback function.</div>
9393
<code class="indented">{{highlightListenerOutput}}</code>
9494
</div>
95+
<div v-if="editorParams.abcjsParams.add_classes">
96+
<div class="footnote"><span>You can see the added classes by inspecting the generated SVG using the browser's development tools. For a visual look at the classes, go to the <nuxt-link to="/classes">Classes</nuxt-link> page.</span></div>
97+
<code class="indented">{{highlightListenerOutput}}</code>
98+
</div>
9599
<div v-if="editorParams.abcjsParams.responsive === 'resize'">
96100
<div class="footnote"><span>When using resize, do not place the </span><code class="subtle-code">&lt;div id="paper"&gt;</code><span> as a flex element: the flex functionality will interfere. Just wrap in another </span><code class="subtle-code">&lt;div&gt;</code></div>
97101
</div>
@@ -244,7 +248,6 @@ K:Em
244248
if (this.editorParams.specifyDownloadMidiId || this.editorParams.specifyInlineMidiId) {
245249
params += "\n generate_midi: true,";
246250
if (this.editorParams.specifyDownloadMidiId) {
247-
params += "\n generateDownload: true,";
248251
params += "\n midi_download_id: \"midi-download\",";
249252
}
250253
if (this.editorParams.specifyInlineMidiId) {
@@ -296,6 +299,8 @@ K:Em
296299
params.push("clickListener: function(abcElem) { console.log(abcElem, tuneNumber); },");
297300
if (this.editorParams.abcjsParams.responsiveResize)
298301
params.push("responsive: \"resize\",");
302+
if (this.editorParams.specifyDownloadMidiId)
303+
params.push("generateDownload: true,");
299304
if (params.length === 0)
300305
params = "{ }";
301306
else

0 commit comments

Comments
 (0)