Skip to content

Commit 27e5d2a

Browse files
authored
Merge pull request kubernetes-sigs#1129 from M00nF1sh/fargate-enhance
ignore fargate nodes for instance target type
2 parents bc6519d + b58bba7 commit 27e5d2a

File tree

1 file changed

+3
-0
lines changed
  • internal/ingress/annotations/class

1 file changed

+3
-0
lines changed

internal/ingress/annotations/class/main.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ func IsValidIngress(ingressClass string, ingress *extensions.Ingress) bool {
4343
// TODO: change this to in-sync with https://github.com/kubernetes/kubernetes/blob/13705ac81e00f154434b5c66c1ad92ac84960d7f/pkg/controller/service/service_controller.go#L592(relies on node's ready condition instead of AWS API)
4444
// IsValidNode returns true if the given Node has valid annotations
4545
func IsValidNode(n *corev1.Node) bool {
46+
if s, ok := n.ObjectMeta.Labels["eks.amazonaws.com/compute-type"]; ok && s == "fargate" {
47+
return false
48+
}
4649
if _, ok := n.ObjectMeta.Labels["node-role.kubernetes.io/master"]; ok {
4750
return false
4851
}

0 commit comments

Comments
 (0)