TST: [ArrowStringArray] add dtype parameterisation to test_astype_float and test_fillna_args #40677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…d test_fillna_args
simonjayhawkins added Testing 
Contributor
| thanks @simonjayhawkins |
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
…d test_fillna_args (pandas-dev#40677)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
…d test_fillna_args (pandas-dev#40677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#35259 added dtype parameterisation to existing tests in pandas/tests/arrays/string_/test_string.py and xfailed for ArrowStringArray where needed.
test_astype_float and test_fillna_args were later added in #37974 and #37987 respectively.
This PR doesn't fix (although will be looking at the all the xfailed tests in this module shortly, #35169 (comment)) just xfails to reduce the diff (slightly) for #39908