Skip to content

BUG: Validate drop_duplicates ignore_index argument for bool #38277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2020
Merged

BUG: Validate drop_duplicates ignore_index argument for bool #38277

merged 1 commit into from
Dec 4, 2020

Conversation

@phofl
Copy link
Member

@phofl phofl commented Dec 3, 2020 •
edited
Loading

Saw this on the tracker. I think we should validate this, some inputs could lead to weird results.
The last drop duplicates entry in whatsnew was also under reshaping, so put it there
@jreback jreback added the Error Reporting Incorrect or improved errors from pandas label Dec 4, 2020
@jreback jreback added this to the 1.2 milestone Dec 4, 2020
@jreback jreback merged commit e132d85 into pandas-dev:master Dec 4, 2020
@jreback
Copy link
Contributor

jreback commented Dec 4, 2020

thanks @phofl
@phofl phofl deleted the 38274 branch December 4, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Error Reporting Incorrect or improved errors from pandas

2 participants

@phofl @jreback