ENH: implement _should_compare/_is_comparable_dtype for all Index subclasses #38251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback added Index 
Contributor
| de-duplicate away! |
| missing = np.arange(3, dtype=np.intp) | ||
| tm.assert_numpy_array_equal(result[0], expected) | ||
| tm.assert_numpy_array_equal(result[1], expected) | ||
| tm.assert_numpy_array_equal(result[1], missing) |
Member
There was a problem hiding this comment.
What's the reason for changing the behaviour here?
Did you consider this a bug?
Member Author
There was a problem hiding this comment.
Yes. As mentioned in the OP, as far as i can tell it isnt actually affecting anything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes some problems in get_indexer_non_unique that AFAICT are not actually causing any problems.
Categorical kludge is needed because of #38240.