CLN: assorted cleanups #30575
Merged
CLN: assorted cleanups #30575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
topper-123 approved these changes Dec 31, 2019
| - Bug in :class:`DatetimeIndex` addition when adding a non-optimized :class:`DateOffset` incorrectly dropping timezone information (:issue:`30336`) | ||
| - Bug in :meth:`DataFrame.drop` where attempting to drop non-existent values from a DatetimeIndex would yield a confusing error message (:issue:`30399`) | ||
| - Bug in :meth:`DataFrame.append` would remove the timezone-awareness of new data (:issue:`30238`) | ||
| - Bug in :meth:`Series.cummin` and :meth:`Series.cummax` with timezone-aware dtype incorrectly dropping its timezone (:issue:`15553`) |
simonjayhawkins approved these changes Dec 31, 2019
| def _get_new_axes(self) -> List[Index]: | ||
| ndim = self._get_result_dim() | ||
| new_axes = [None] * ndim | ||
| new_axes: List = [None] * ndim |
Member
There was a problem hiding this comment.
can you add type parameters at some point. xref #30539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Salvaging what I can from some abandoned branches.