remove period_helper from non-period reqs #17531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hello @jbrockmendel! Thanks for submitting the PR.
|
| looks fine. ping on green. |
jreback added the Compat 
Codecov Report
@@ Coverage Diff @@ ## master #17531 +/- ## ========================================== - Coverage 91.24% 91.2% -0.05% ========================================== Files 163 163 Lines 49582 49586 +4 ========================================== - Hits 45242 45225 -17 - Misses 4340 4361 +21
Continue to review full report at Codecov.
|
| ping. |
| thanks! |
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There are a bunch of other reqs that could be removed (e.g. every direct reference to src/util, all of
lib_depends), but at leastperiod_helperit's obvious why it belongs where it does.git diff upstream/master -u -- "*.py" | flake8 --diff