COMPAT: ensure proper extension dtype's don't pickle the cache #16207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jreback added Compat 
max-sixty reviewed May 2, 2017
pandas/core/dtypes/dtypes.py Outdated
| return {k: getattr(self, k, None) for k in self._metadata} | ||
| | ||
| def __setstate__(self, state): | ||
| self.__dict__.update(state) |
Contributor
There was a problem hiding this comment.
FWIW this is the default behavior if there is no __setstate__ method
Contributor Author
There was a problem hiding this comment.
yeah I know, wanted to make it explicit :>
Codecov Report
@@ Coverage Diff @@ ## master #16207 +/- ## ========================================== + Coverage 90.86% 90.89% +0.02% ========================================== Files 162 162 Lines 50867 50879 +12 ========================================== + Hits 46222 46246 +24 + Misses 4645 4633 -12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #16207 +/- ## ========================================== + Coverage 90.86% 90.89% +0.02% ========================================== Files 162 162 Lines 50867 50879 +12 ========================================== + Hits 46222 46246 +24 + Misses 4645 4633 -12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #16207 +/- ## ========================================== + Coverage 90.86% 90.86% +<.01% ========================================== Files 162 162 Lines 50867 50881 +14 ========================================== + Hits 46222 46235 +13 - Misses 4645 4646 +1
Continue to review full report at Codecov.
|
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
yarikoptic added a commit to neurodebian/pandas that referenced this pull request Jul 12, 2017
Version 0.20.0 * tag 'v0.20.0': (742 commits) RLS: v0.20.0 DOC: Whatsnew cleanup (pandas-dev#16245) TST: Test CategoricalIndex in test_is_categorical (pandas-dev#16243) TST: xfail some bottleneck on windows (pandas-dev#16240) DOC, TST: Document and Test Functions in dtypes/common.py (pandas-dev#16237) TST: Remove __init__ statements in testing (pandas-dev#16238) DOC: don't include all methods/attributes of IntervalIndex (pandas-dev#16221) PKG: Fix ModuleNotFoundError: No module named 'pandas.formats' (pandas-dev#16239) RLS: v0.20.0rc2 CLN: make submodules of pandas.util private (pandas-dev#16223) MAINT: Remove tm.TestCase from testing (pandas-dev#16225) MAINT: Complete Conversion to Pytest Idiom (pandas-dev#16201) DOC: add whatsnew for 0.21.0 DEPR: correct deprecation message for datetools (pandas-dev#16202) API Change repr name for table schema (pandas-dev#16204) DOC: Remove various warnings from doc build (pandas-dev#16206) DOC: add whatsnew for v0.20.1 BUG: Fixed renaming of falsey names in build_table_schema (pandas-dev#16205) COMPAT: ensure proper extension dtype's don't pickle the cache (pandas-dev#16207) REF: register custom DisplayFormatter for table schema (pandas-dev#16198) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
xref #16201