Skip to content

Conversation

@cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Jan 19, 2017

@sinhrks
Copy link
Member

sinhrks commented Jan 19, 2017

Pls add tests to check font size, using _check_ticks_props.

@sinhrks sinhrks added the Visualization plotting label Jan 19, 2017
@cbrnr
Copy link
Contributor Author

cbrnr commented Jan 19, 2017

Sure - I added a test for both TestDataFramePlots and TestDataFrameGroupByPlots. Let me know if only one test (the former?) is sufficient though.

@sinhrks
Copy link
Member

sinhrks commented Jan 20, 2017

lgtm. pls add whats new note.

@TomAugspurger ?

@cbrnr
Copy link
Contributor Author

cbrnr commented Jan 20, 2017

OK - I hope this was the right place to add the note.

@TomAugspurger TomAugspurger merged commit b342331 into pandas-dev:master Jan 20, 2017
@TomAugspurger
Copy link
Contributor

Thanks!

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
* Apply fontsize to both x- and y-axis tick labels * Add tests * Add note in whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants