Skip to content

Commit dd2b1e1

Browse files
committed
required changes done
1 parent bcb5bb9 commit dd2b1e1

File tree

6 files changed

+36
-42
lines changed

6 files changed

+36
-42
lines changed

pandas/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,8 @@ def pytest_collection_modifyitems(items, config) -> None:
139139
("missing.mask_zero_div_zero", "divide by zero encountered"),
140140
(
141141
"pandas.core.generic.NDFrame.bool",
142-
"NDFrame.bool is now deprecated and will be removed in future releases "
143-
"and cases that relied on it will raise in a future version",
142+
"NDFrame.bool is now deprecated and will be removed in future version of pandas "
143+
"and cases that relied on it will raise a future warning",
144144
),
145145
]
146146

pandas/core/generic.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1503,8 +1503,8 @@ def bool(self) -> bool_t:
15031503
"""
15041504

15051505
warnings.warn(
1506-
"NDFrame.bool is now deprecated and will be removed in future releases "
1507-
"and cases that relied on it will raise in a future version",
1506+
"type(self).__name__ is now deprecated and will be removed in future "
1507+
"version of pandas and cases that relied on it will raise a future warning",
15081508
FutureWarning,
15091509
stacklevel=find_stack_level(),
15101510
)

pandas/tests/generic/test_frame.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ def test_set_axis_name_mi(self, func):
4848
def test_nonzero_single_element(self):
4949
# allow single item via bool method
5050
msg = (
51-
"NDFrame.bool is now deprecated and will be removed in future releases "
52-
"and cases that relied on it will raise in a future version"
51+
"NDFrame.bool is now deprecated and will be removed in future version of pandas "
52+
"and cases that relied on it will raise a future warning"
5353
)
54-
with tm.assert_produces_warning(FutureWarning, match=msg):
55-
df = DataFrame([[True]])
54+
df = DataFrame([[True]])
55+
df1 = DataFrame([[False]])
56+
while tm.assert_produces_warning(FutureWarning, match=msg):
5657
assert df.bool()
5758

58-
df = DataFrame([[False]])
59-
assert not df.bool()
59+
assert not df1.bool()
6060

6161
df = DataFrame([[False, False]])
6262
msg = "The truth value of a DataFrame is ambiguous"

pandas/tests/generic/test_generic.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -444,8 +444,8 @@ def test_flags_identity(self, frame_or_series):
444444

445445
def test_bool_dep(self) -> None:
446446
msg = (
447-
"NDFrame.bool is now deprecated and will be removed in future releases "
448-
"and cases that relied on it will raise in a future version"
447+
"NDFrame.bool is now deprecated and will be removed in future version of pandas "
448+
"and cases that relied on it will raise a future warning"
449449
)
450450
with tm.assert_produces_warning(FutureWarning, match=msg):
451451
DataFrame({"col": [False]}).bool()

pandas/tests/generic/test_series.py

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,15 @@ def test_get_bool_data_preserve_dtype(self):
4242
def test_nonzero_single_element(self):
4343
# allow single item via bool method
4444
msg = (
45-
"NDFrame.bool is now deprecated and will be removed in future releases "
46-
"and cases that relied on it will raise in a future version"
45+
"NDFrame.bool is now deprecated and will be removed in future version of pandas "
46+
"and cases that relied on it will raise a future warning"
4747
)
48-
with tm.assert_produces_warning(FutureWarning, match=msg):
49-
ser = Series([True])
48+
ser = Series([True])
49+
ser1 = Series([False])
50+
while tm.assert_produces_warning(FutureWarning, match=msg):
5051
assert ser.bool()
5152

52-
ser = Series([False])
53-
assert not ser.bool()
53+
assert not ser1.bool()
5454

5555
@pytest.mark.parametrize("data", [np.nan, pd.NaT, True, False])
5656
def test_nonzero_single_element_raise_1(self, data):
@@ -64,12 +64,11 @@ def test_nonzero_single_element_raise_1(self, data):
6464
@pytest.mark.parametrize("data", [np.nan, pd.NaT])
6565
def test_nonzero_single_element_raise_2(self, data):
6666
msg = (
67-
"NDFrame.bool is now deprecated and will be removed in future releases "
68-
"and cases that relied on it will raise in a future version"
67+
"NDFrame.bool is now deprecated and will be removed in future version of pandas "
68+
"and cases that relied on it will raise a future warning"
6969
)
70-
with tm.assert_produces_warning(FutureWarning, match=msg):
71-
series = Series([data])
72-
70+
series = Series([data])
71+
while tm.assert_produces_warning(FutureWarning, match=msg):
7372
msg = "bool cannot act on a non-boolean single element Series"
7473
with pytest.raises(ValueError, match=msg):
7574
series.bool()
@@ -78,12 +77,11 @@ def test_nonzero_single_element_raise_2(self, data):
7877
def test_nonzero_multiple_element_raise(self, data):
7978
# multiple bool are still an error
8079
msg = (
81-
"NDFrame.bool is now deprecated and will be removed in future releases "
82-
"and cases that relied on it will raise in a future version"
80+
"NDFrame.bool is now deprecated and will be removed in future version of pandas "
81+
"and cases that relied on it will raise a future warning"
8382
)
84-
with tm.assert_produces_warning(FutureWarning, match=msg):
85-
series = Series([data])
86-
83+
series = Series([data])
84+
while tm.assert_produces_warning(FutureWarning, match=msg):
8785
msg = "The truth value of a Series is ambiguous"
8886
with pytest.raises(ValueError, match=msg):
8987
bool(series)
@@ -94,8 +92,8 @@ def test_nonzero_multiple_element_raise(self, data):
9492
def test_nonbool_single_element_raise(self, data):
9593
# single non-bool are an error
9694
msg = (
97-
"NDFrame.bool is now deprecated and will be removed in future releases "
98-
"and cases that relied on it will raise in a future version"
95+
"NDFrame.bool is now deprecated and will be removed in future version of pandas "
96+
"and cases that relied on it will raise a future warning"
9997
)
10098
with tm.assert_produces_warning(FutureWarning, match=msg):
10199
series = Series([data])

pandas/tests/window/test_timeseries_window.py

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -506,18 +506,14 @@ def test_perf_min(self):
506506
dfp = DataFrame(
507507
{"B": np.random.randn(N)}, index=date_range("20130101", periods=N, freq="s")
508508
)
509-
msg = (
510-
"NDFrame.bool is now deprecated and will be removed in future releases "
511-
"and cases that relied on it will raise in a future version"
512-
)
513-
with tm.assert_produces_warning(FutureWarning, match=msg):
514-
expected = dfp.rolling(2, min_periods=1).min()
515-
result = dfp.rolling("2s").min()
516-
assert ((result - expected) < 0.01).all().bool()
517-
518-
expected = dfp.rolling(200, min_periods=1).min()
519-
result = dfp.rolling("200s").min()
520-
assert ((result - expected) < 0.01).all().bool()
509+
510+
expected = dfp.rolling(2, min_periods=1).min()
511+
result = dfp.rolling("2s").min()
512+
assert ((result - expected) < 0.01).all() == True
513+
514+
expected = dfp.rolling(200, min_periods=1).min()
515+
result = dfp.rolling("200s").min()
516+
assert ((result - expected) < 0.01).all() == True
521517

522518
def test_ragged_max(self, ragged):
523519
df = ragged

0 commit comments

Comments
 (0)