simplify

Author: jbrockmendel

pandas/tests/io/excel/test_readers.py

@@ -128,13 +128,16 @@ def df_ref(datapath):
  return df_ref
 
 
-def adjust_expected(expected: DataFrame, read_ext: str, engine: str | None) -> None:
- expected.index.name = None
-
+def get_exp_unit(read_ext: str, engine: str | None) -> str:
  unit = "us"
  if (read_ext == ".ods") ^ (engine == "calamine"):
- # TODO: why is .ods & calamine a separate special case?
  unit = "s"
+ return unit
+
+
+def adjust_expected(expected: DataFrame, read_ext: str, engine: str | None) -> None:
+ expected.index.name = None
+ unit = get_exp_unit(read_ext, engine)
  expected.index = expected.index.as_unit(unit)
 
 
@@ -307,11 +310,6 @@ def test_usecols_diff_positional_int_columns_order(
 
  expected = df_ref[["A", "C"]]
  adjust_expected(expected, read_ext, engine)
- if engine == "calamine":
- unit = "s"
- if read_ext == ".ods": # WTF?
- unit = "us"
- expected.index = expected.index.as_unit(unit)
 
  result = pd.read_excel(
  "test1" + read_ext, sheet_name="Sheet1", index_col=0, usecols=usecols
@@ -455,24 +453,26 @@ def test_excel_table(self, request, engine, read_ext, df_ref):
  def test_reader_special_dtypes(self, request, engine, read_ext):
  xfail_datetimes_with_pyxlsb(engine, request)
 
+ unit = get_exp_unit(read_ext, engine)
  expected = DataFrame.from_dict(
  {
  "IntCol": [1, 2, -3, 4, 0],
  "FloatCol": [1.25, 2.25, 1.83, 1.92, 0.0000000005],
  "BoolCol": [True, False, True, True, False],
  "StrCol": [1, 2, 3, 4, 5],
  "Str2Col": ["a", 3, "c", "d", "e"],
- "DateCol": [
- datetime(2013, 10, 30),
- datetime(2013, 10, 31),
- datetime(1905, 1, 1),
- datetime(2013, 12, 14),
- datetime(2015, 3, 14),
- ],
+ "DateCol": Index(
+ [
+ datetime(2013, 10, 30),
+ datetime(2013, 10, 31),
+ datetime(1905, 1, 1),
+ datetime(2013, 12, 14),
+ datetime(2015, 3, 14),
+ ],
+ dtype=f"M8[{unit}]",
+ ),
  },
  )
- if (read_ext == ".ods") ^ (engine == "calamine"):
- expected["DateCol"] = expected["DateCol"].astype("M8[s]")
  basename = "test_types"
 
  # should read in correctly and infer types
@@ -632,8 +632,8 @@ def test_dtype_backend(self, read_ext, dtype_backend, engine):
  expected["j"] = ArrowExtensionArray(pa.array([None, None]))
  else:
  expected = df
- if not ((read_ext == ".ods") ^ (engine == "calamine")):
-  expected["i"] = expected["i"].astype("M8[us]")
+ unit = get_exp_unit(read_ext, engine)
+ expected["i"] = expected["i"].astype(f"M8[{unit}]")
 
  tm.assert_frame_equal(result, expected)
 
@@ -1025,9 +1025,7 @@ def test_read_excel_multiindex(self, request, engine, read_ext):
  if engine == "calamine" and read_ext == ".ods":
  request.applymarker(pytest.mark.xfail(reason="Last test fails in calamine"))
 
- unit = "us"
- if (read_ext == ".ods") ^ (engine == "calamine"):
- unit = "s"
+ unit = get_exp_unit(read_ext, engine)
 
  mi = MultiIndex.from_product([["foo", "bar"], ["a", "b"]])
  mi_file = "testmultiindex" + read_ext
@@ -1122,9 +1120,9 @@ def test_read_excel_multiindex_blank_after_name(
 
  mi_file = "testmultiindex" + read_ext
  mi = MultiIndex.from_product([["foo", "bar"], ["a", "b"]], names=["c1", "c2"])
- unit = "us"
- if (read_ext == ".ods") ^ (engine == "calamine"):
- unit = "s"
+
+ unit = get_exp_unit(read_ext, engine)
+
  expected = DataFrame(
  [
  [1, 2.5, pd.Timestamp("2015-01-01").as_unit(unit), True],
@@ -1241,13 +1239,7 @@ def test_read_excel_skiprows(self, request, engine, read_ext):
  # GH 4903
  xfail_datetimes_with_pyxlsb(engine, request)
 
- unit = "us"
- if read_ext == ".ods":
- unit = "s"
- if engine == "calamine":
- unit = "us"
- elif engine == "calamine":
- unit = "s"
+ unit = get_exp_unit(read_ext, engine)
 
  actual = pd.read_excel(
  "testskiprows" + read_ext, sheet_name="skiprows_list", skiprows=[0, 2]
@@ -1300,13 +1292,7 @@ def test_read_excel_skiprows(self, request, engine, read_ext):
  def test_read_excel_skiprows_callable_not_in(self, request, engine, read_ext):
  # GH 4903
  xfail_datetimes_with_pyxlsb(engine, request)
- unit = "us"
- if read_ext == ".ods":
- unit = "s"
- if engine == "calamine":
- unit = "us" # WTF?
- elif engine == "calamine":
- unit = "s"
+ unit = get_exp_unit(read_ext, engine)
 
  actual = pd.read_excel(
  "testskiprows" + read_ext,
@@ -1578,11 +1564,6 @@ def test_excel_table_sheet_by_index(self, request, engine, read_ext, df_ref):
 
  expected = df_ref
  adjust_expected(expected, read_ext, engine)
- if engine == "calamine":
- unit = "s"
- if read_ext == ".ods":
- unit = "us"
- expected.index = expected.index.as_unit(unit)
 
  with pd.ExcelFile("test1" + read_ext) as excel:
  df1 = pd.read_excel(excel, sheet_name=0, index_col=0)
@@ -1610,11 +1591,6 @@ def test_sheet_name(self, request, engine, read_ext, df_ref):
 
  expected = df_ref
  adjust_expected(expected, read_ext, engine)
- if engine == "calamine":
- unit = "s"
- if read_ext == ".ods":
- unit = "us"
- expected.index = expected.index.as_unit(unit)
 
  filename = "test1"
  sheet_name = "Sheet1"
@@ -1706,9 +1682,7 @@ def test_read_datetime_multiindex(self, request, engine, read_ext):
  f = "test_datetime_mi" + read_ext
  with pd.ExcelFile(f) as excel:
  actual = pd.read_excel(excel, header=[0, 1], index_col=0, engine=engine)
- unit = "us"
- if (read_ext == ".ods") ^ (engine == "calamine"):
- unit = "s"
+ unit = get_exp_unit(read_ext, engine)
  expected_column_index = MultiIndex.from_tuples(
  [
  (