Search by analyzer

[svenpilz]

No description provided.

[tarzanek]

could above be autogenerated from analyzers?
just want to save steps when someone adds new analyzer
obviously we can accept it like this, but long term above needs to be dynamic to save footprint of changes when adding new analyzer

[svenpilz]

I don't see how those could be autogenerated, “csharp” and “plsql” are good examples.

What about a new method getFileTypeDescription in FileAnalyzer, that, by default, returns the file type (fortran => Fortran, etc.) and can be overridden to give the proper string? Then getFileTypeDescirptions would iterate over all registered analyzers to give the list.

[tarzanek]

yeah, exactly how I meant it
you can also return array of tuples, which would fix the csharp and plsql problem
anyways, if you agree with OCA, I will integrate this patch and we can merge a fix for above in a new pull

[tarzanek]

lovely, thank you guys
this would close issue #43 , besides the dynamic creation of the map I have no other comments and I'd happy accept it

one thing needs to be sorted out - the legal stuff
I can accept it with your credit only if you agree to http://www.oracle.com/technetwork/oca-405177.pdf - http://www.oracle.com/technetwork/community/oca-486395.html

• you can either follow the process described there and send/mail the papers back to Oracle to get a contributor id/number - this makes sense if you plan to contribute any other patches to Opengrok, since you will be known to Oracle lawyers as a contributor

or the fast process is that you read above agreement and say that you agree here - basically OCA is a paper where you give Oracle rights to use your patch and promise you won't sue Oracle over this patch

vielen dank!
L

[svenpilz]

I agree.

[tarzanek]

Thanks Sven, your code is in upstream
for my comment please create a new pull request
(I'll try to have a look at it, too, but not sure if I will have so much time in next 3 weeks :( )