Skip to content

Commit 2a5e5f5

Browse files
authored
Removed close api changes and moved to seperate PR
1 parent 8f2a6e5 commit 2a5e5f5

File tree

5 files changed

+0
-38
lines changed

5 files changed

+0
-38
lines changed

android/src/main/java/com/optimizely/optimizely_flutter_sdk/OptimizelyFlutterClient.java

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -364,25 +364,6 @@ protected void getOptimizelyConfig(ArgumentsParser argumentsParser, @NonNull Res
364364
result.success(createResponse(true, optimizelyConfigMap, SuccessMessage.OPTIMIZELY_CONFIG_FOUND));
365365
}
366366

367-
protected void close(ArgumentsParser argumentsParser, @NonNull Result result) {
368-
String sdkKey = argumentsParser.getSdkKey();
369-
if (sdkKey == null) {
370-
result.success(createResponse(false, ErrorMessage.INVALID_PARAMS));
371-
return;
372-
}
373-
OptimizelyClient optimizelyClient = getOptimizelyClient(sdkKey);
374-
if (optimizelyClient == null) {
375-
result.success(createResponse(false, ErrorMessage.OPTIMIZELY_CLIENT_NOT_FOUND));
376-
return;
377-
}
378-
optimizelyClient.close();
379-
380-
optimizelyManagerTracker.remove(sdkKey);
381-
userContextsTracker.remove(sdkKey);
382-
383-
result.success(createResponse(true, SuccessMessage.OPTIMIZELY_CLIENT_CLOSED));
384-
}
385-
386367
public Map<String, ?> createResponse(Boolean success, Object result, String reason) {
387368
Map<String, Object> response = new HashMap<>();
388369
response.put(ResponseKey.SUCCESS, success);

android/src/main/java/com/optimizely/optimizely_flutter_sdk/OptimizelyFlutterSdkPlugin.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,6 @@ public void onMethodCall(@NonNull MethodCall call, @NonNull Result result) {
9090
removeAllForcedDecisions(argumentsParser, result);
9191
break;
9292
}
93-
case APIs.CLOSE: {
94-
close(argumentsParser, result);
95-
break;
96-
}
9793
default:
9894
result.notImplemented();
9995
}

android/src/main/java/com/optimizely/optimizely_flutter_sdk/helper_classes/Constants.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
public class Constants {
1919
public static class APIs {
20-
public static final String CLOSE = "close";
2120
public static final String INITIALIZE = "initialize";
2221
public static final String GET_OPTIMIZELY_CONFIG = "getOptimizelyConfig";
2322
public static final String CREATE_USER_CONTEXT = "createUserContext";
@@ -65,7 +64,6 @@ public static class ErrorMessage {
6564
public static class SuccessMessage {
6665
public static final String INSTANCE_CREATED = "Optimizely instance created successfully.";
6766
public static final String OPTIMIZELY_CONFIG_FOUND = "Optimizely config found.";
68-
public static final String OPTIMIZELY_CLIENT_CLOSED = "Optimizely client closed successfully.";
6967
public static final String USER_CONTEXT_CREATED = "User context created successfully.";
7068
public static final String LISTENER_REMOVED = "Listener removed successfully.";
7169
public static final String DECIDE_CALLED = "Decide called successfully.";

lib/optimizely_flutter_sdk.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,6 @@ class OptimizelyFlutterSdk {
5959
_sdkKey, userId, attributes);
6060
}
6161

62-
/// Checks if eventHandler are Closeable and calls close on them.
63-
Future<BaseResponse> close() async {
64-
return await OptimizelyClientWrapper.close(_sdkKey);
65-
}
66-
6762
Future<CancelListening> addDecisionNotificationListener(
6863
MultiUseCallback callback) async {
6964
return await _addNotificationListener(callback, ListenerType.decision);

lib/src/optimizely_client_wrapper.dart

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,6 @@ class OptimizelyClientWrapper {
4949
return OptimizelyConfigResponse(result);
5050
}
5151

52-
/// Returns a success true if optimizely client closed successfully.
53-
static Future<BaseResponse> close(
54-
String sdkKey) async {
55-
final result = Map<String, dynamic>.from(await _channel.invokeMethod(
56-
Constants.close, {Constants.sdkKey: sdkKey}));
57-
return BaseResponse(result);
58-
}
59-
6052
/// Creates a context of the user for which decision APIs will be called.
6153
///
6254
/// A user context will only be created successfully when the SDK is fully configured using initializeClient.

0 commit comments

Comments
 (0)