Implement getFeatureVariable and create tests #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 similar comment
mikeproeng37 suggested changes Jun 28, 2019
mikeproeng37 suggested changes Jul 1, 2019
Contributor
mikeproeng37 left a comment
mikeproeng37 left a comment There was a problem hiding this comment.
Almost there! Just a few changes.
Contributor
| Also, please merge the latest master into your branch and push that with your next commit. |
thomaszurkan-optimizely approved these changes Jul 2, 2019
thomaszurkan-optimizely left a comment
thomaszurkan-optimizely left a comment There was a problem hiding this comment.
LGTM. Mike's comments seem spot on. Nice!
mikeproeng37 approved these changes Jul 2, 2019
aliabbasrizvi suggested changes Jul 2, 2019
brandonhudavid changed the title Contributor
| Passing build here: https://travis-ci.com/optimizely/fullstack-sdk-compatibility-suite/builds/119044040 using FSC PR: https://github.com/optimizely/fullstack-sdk-compatibility-suite/pull/303 @aliabbasrizvi please unblock this when you get a chance so we can merge this in and then merge in the FSC PR. |
This was referenced Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
getFeatureVariablemethod to return value of variable with any typegetFeatureVariableSince Javascript is a dynamically-typed language, it suffices to have a single method return the value of a feature variable rather than have a separate method for each possible feature variable type.
Test plan
getFeatureVariablegetFeatureVariablewith specific typeIssues