Skip to content

feat(flag-decisions): Add support for sending flag decisions along with decision metadata. #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 20, 2020
Merged

feat(flag-decisions): Add support for sending flag decisions along with decision metadata. #244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4cf5f43
Implemented flag decision logic
mnoman09 Sep 24, 2020
314f13b
added check that if SendFlagDecision is true then send the event
mnoman09 Sep 25, 2020
1bf73ea
- Added unit tests of featureDecision,
mnoman09 Sep 25, 2020
d82558d
Updated headers
mnoman09 Sep 25, 2020
8183bcc
passing null variation as variable
mnoman09 Sep 27, 2020
94a5821
unit test fix converted to snakecase
mnoman09 Sep 27, 2020
315aa55
removed invalid path decision metadata from cs16proj
mnoman09 Sep 28, 2020
823bdb2
Added test to check sendFlagDecision is false in case if it's missing…
mnoman09 Sep 29, 2020
719eb73
reverted changes made in this file
mnoman09 Sep 30, 2020
c6dc84f
Merge branch 'master' into mnoman/flag-decision
pawels-optimizely Oct 1, 2020
724a86b
Reverted removal of Activating user log and added condition to do n…
mnoman09 Oct 1, 2020
2aa8e8d
Renamed flag_type to rule_type and added rule_key
mnoman09 Oct 12, 2020
e5a4ae8
Added decision to rollout
mnoman09 Oct 13, 2020
e8db3cb
when variation is null then ruleType will be rollout
mnoman09 Oct 13, 2020
6c8d8f1
unit test fix
mnoman09 Oct 13, 2020
8c13a0e
Refact: made experiment constant
mnoman09 Oct 13, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reverted removal of Activating user log and added condition to do not… 
… log if experiment is null
  • Loading branch information
@mnoman09
mnoman09 committed Oct 1, 2020
commit 724a86bccc82bbaf1a82b88799677e3ab01ca2f3
6 changes: 6 additions & 0 deletions OptimizelySDK.Tests/OptimizelyTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ public void TestActivateNoAudienceNoAttributes()
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "User [user_1] is in experiment [group_experiment_1] of group [7722400015]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.DEBUG, "Assigned bucket [9525] to user [user_1] with bucketing ID [user_1]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "User [user_1] is in variation [group_exp_1_var_2] of experiment [group_experiment_1]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "Activating user user_1 in experiment group_experiment_1."), Times.Once);

Assert.IsTrue(TestData.CompareObjects(GroupVariation, variation));
}
Expand Down Expand Up @@ -429,6 +430,7 @@ public void TestActivateWithAttributes()
LoggerMock.Verify(l => l.Log(LogLevel.DEBUG, "Assigned bucket [3037] to user [test_user] with bucketing ID [test_user]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "User [test_user] is in variation [control] of experiment [test_experiment]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "This decision will not be saved since the UserProfileService is null."));
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "Activating user test_user in experiment test_experiment."), Times.Once);

Assert.IsTrue(TestData.CompareObjects(VariationWithKeyControl, variation));
}
Expand All @@ -448,6 +450,7 @@ public void TestActivateWithNullAttributes()
LoggerMock.Verify(l => l.Log(LogLevel.DEBUG, "User \"test_user\" is not in the forced variation map."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.DEBUG, "Assigned bucket [3037] to user [test_user] with bucketing ID [test_user]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "User [test_user] is in variation [control] of experiment [test_experiment]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "Activating user test_user in experiment test_experiment."), Times.Once);

Assert.IsTrue(TestData.CompareObjects(VariationWithKeyControl, variation));
}
Expand Down Expand Up @@ -487,6 +490,7 @@ public void TestActivateWithTypedAttributes()

LoggerMock.Verify(l => l.Log(LogLevel.DEBUG, "Assigned bucket [3037] to user [test_user] with bucketing ID [test_user]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "User [test_user] is in variation [control] of experiment [test_experiment]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "Activating user test_user in experiment test_experiment."), Times.Once);

Assert.IsTrue(TestData.CompareObjects(VariationWithKeyControl, variation));
}
Expand Down Expand Up @@ -680,6 +684,7 @@ public void TestInvalidDispatchImpressionEvent()
LoggerMock.Verify(l => l.Log(LogLevel.DEBUG, "Assigned bucket [3037] to user [test_user] with bucketing ID [test_user]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "User [test_user] is in variation [control] of experiment [test_experiment]."), Times.Once);

LoggerMock.Verify(l => l.Log(LogLevel.INFO, "Activating user test_user in experiment test_experiment."), Times.Once);
// Need to see how error handler can be verified.
LoggerMock.Verify(l => l.Log(LogLevel.ERROR, It.IsAny<string>()), Times.Once);

Expand Down Expand Up @@ -1074,6 +1079,7 @@ public void TestActivateNoAudienceNoAttributesAfterSetForcedVariation()
LoggerMock.Verify(l => l.Log(LogLevel.DEBUG, "Assigned bucket [9525] to user [user_1] with bucketing ID [user_1]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "User [user_1] is in variation [group_exp_1_var_2] of experiment [group_experiment_1]."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "This decision will not be saved since the UserProfileService is null."), Times.Once);
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "Activating user user_1 in experiment group_experiment_1."), Times.Once);

Assert.IsTrue(TestData.CompareObjects(GroupVariation, variation));
}
Expand Down
5 changes: 4 additions & 1 deletion OptimizelySDK/Optimizely.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,8 +701,11 @@ private void SendImpressionEvent(Experiment experiment, Variation variation, str
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should log at this point.
}
EventProcessor.Process(userEvent);
//Logger.Log(LogLevel.INFO, $"Activating user {userId} in experiment {experiment.Key}.");

if (experiment != null)
{
Logger.Log(LogLevel.INFO, $"Activating user {userId} in experiment {experiment.Key}.");
}
// Kept For backwards compatibility.
// This notification is deprecated and the new DecisionNotifications
// are sent via their respective method calls.
Expand Down