Skip to content

Conversation

stampaaaron
Copy link
Contributor

No description provided.

@stampaaaron stampaaaron requested a review from openscript June 15, 2023 13:17
@stampaaaron stampaaaron linked an issue Jun 15, 2023 that may be closed by this pull request
4 tasks
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/react-alternating-timeline.es.js 2.09 KB (-74.66% 🔽)
./dist/react-alternating-timeline.umd.js 2.28 KB (-73.09% 🔽)
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #101 (92df745) into main (11e1687) will not change coverage.
The diff coverage is 66.66%.

@@ Coverage Diff @@ ## main #101 +/- ## ======================================= Coverage 13.75% 13.75% ======================================= Files 4 4 Lines 80 80 Branches 20 20 ======================================= Hits 11 11 Misses 55 55 Partials 14 14 
Impacted Files Coverage Δ
src/components/Timeline.tsx 0.00% <0.00%> (ø)
src/components/TimelineItem.tsx 100.00% <100.00%> (ø)
Copy link
Member

@openscript openscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes! Reduces the bundle by over 70% and adds more flexibility.

@stampaaaron stampaaaron changed the title 99 redesign date formatting feat: replace date-fns formatting with formatDate callback Jun 15, 2023
@stampaaaron stampaaaron changed the title feat: replace date-fns formatting with formatDate callback feat: replace date-fns formatting with formatDate callback Jun 15, 2023
@stampaaaron stampaaaron changed the title feat: replace date-fns formatting with formatDate callback feat: replace date-fns formatting with formatDate callback Jun 15, 2023
@stampaaaron stampaaaron merged commit 4310e66 into main Jun 15, 2023
@stampaaaron stampaaaron deleted the 99-redesign-date-formatting branch June 15, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants