- Notifications
You must be signed in to change notification settings - Fork 92
fix: exclude musl binaries from function bundle when building on Netlify with pnpm #3145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh approved these changes Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. Just before the merge, it would be good to update PR title to indicate this applies only to buildbot so release notes are not confusing for CLI users expecting improvements with release of this change
musl binaries from function bundle when building on Netlify with pnpm Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
When deploying on Netlify and building with
pnpm, ensure we aren't including packages for bothmuslandgnulibc variants. Without this change, function bundles take up effectively twice as much space.Relevant links (GitHub issues, etc.) or a picture of cute animal
See in-line comments for relevant Github issue links