Skip to content

Commit 3e8c509

Browse files
committed
Merge remote-tracking branch 'origin/master' into 2.0
2 parents 5d71a36 + 73e11fd commit 3e8c509

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

src/Server/Request.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ public function isAjax()
447447
*/
448448
public function isXmlHttpRequest()
449449
{
450-
return $this->hasHeader('X-Requested-With') == 'XMLHttpRequest';
450+
return $this->getHeaderLine('X-Requested-With') == 'XMLHttpRequest';
451451
}
452452

453453
public function getSwooleRequest(): \Swoole\Http\Request

tests/MessageTraitTest.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
namespace HyperfTest\HttpMessage;
1313

1414
use Hyperf\HttpMessage\Base\Request;
15+
use Hyperf\HttpMessage\Server\Request as ServerRequest;
1516
use PHPUnit\Framework\TestCase;
1617

1718
/**
@@ -29,11 +30,22 @@ public function testSetHeaders()
2930
'X-Id' => $id,
3031
'Version' => 1.0,
3132
1000 => 1000,
33+
'X-Requested-With' => 'XMLHttpRequest',
3234
]);
3335

3436
$this->assertSame($token, $request->getHeaderLine('X-Token'));
3537
$this->assertSame((string) $id, $request->getHeaderLine('X-Id'));
3638
$this->assertSame('1', $request->getHeaderLine('Version'));
3739
$this->assertSame('1000', $request->getHeaderLine('1000'));
40+
$this->assertSame('XMLHttpRequest', $request->getHeaderLine('X-Requested-With'));
41+
}
42+
43+
public function testIsXmlHttpRequest()
44+
{
45+
$request = new ServerRequest('GET', '/', [
46+
'X-Requested-With' => 'XMLHttpRequest',
47+
]);
48+
49+
$this->assertTrue($request->isXmlHttpRequest());
3850
}
3951
}

0 commit comments

Comments
 (0)