Skip to content

Commit ec9c199

Browse files
Liudmila Molkovatrask
andcommitted
Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
1 parent e5b2d23 commit ec9c199

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

oteps/4333-recording-exceptions-on-logs.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -115,13 +115,13 @@ or higher severity.
115115
- Errors that don't indicate actual issues SHOULD be recorded with
116116
severity not higher than `Info`.
117117

118-
Such errors can be used to control application logic and have a minor impact, if any,
118+
Such errors have a minor impact, if any,
119119
on application functionality, availability, or performance (beyond the performance hit introduced
120120
if an exception is used to control application logic).
121121

122122
Examples:
123123

124-
- an error is returned when checking the existence of an optional dependency or resource.
124+
- an error is returned when checking the existence of an optional service or resource.
125125
- an exception is thrown on the server when the client disconnects before reading
126126
the full response from the server.
127127

@@ -134,10 +134,10 @@ or higher severity.
134134

135135
Examples:
136136

137-
- an attempt to connect to a required remote dependency times out.
138-
- a remote dependency returns a 401 "Unauthorized" response code.
137+
- an attempt to connect to a remote service times out.
138+
- a remote service returns a 401 "Unauthorized" response code.
139139
- writing data to a file results in an IO exception.
140-
- a remote dependency returns a 503 "Service Unavailable" response for 5 times in a row,
140+
- a remote service returns a 503 "Service Unavailable" response for 5 times in a row,
141141
retry attempts are exhausted, and the corresponding operation fails.
142142

143143
- Unhandled (by the application code) errors that don't result in application

0 commit comments

Comments
 (0)